Feature #37169

Update sanitization rules to allow footnotes markup to match the original structure

Added by Marius BALTEANU 8 months ago. Updated 8 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:


Category:Text formatting
Target version:5.1.0


This is related to #35892.

The sanitisation rules should allow footnotes markup to render as they are generated by commonmark gem for easier customisations.

footnotes.png (232 KB) Marius BALTEANU, 2022-05-31 08:32


#1 Updated by Holger Just 8 months ago

Is this resolved with r21612 already or are there any further required steps?

#2 Updated by Marius BALTEANU 8 months ago

This is how it looks without SanitizationFilter:

And I think it is useful to have the data-footnote-* attributes, the class and even the section element. I've already some working code to obtain this.

What do you think?

#3 Updated by Holger Just 8 months ago

I'm not opposed to this :)

I'm not sure the data attributes are required for us, given that we don't have anything in Redmine which wants this (specifically: no browser JS leveraging those attributes).

The aria-label and class attributes are probably useful though, as might be the section.

Also available in: Atom PDF