Project

General

Profile

Actions

Feature #37169

open

Update sanitization rules to allow footnotes markup to match the original structure

Feature #37169: Update sanitization rules to allow footnotes markup to match the original structure

Added by Marius BĂLTEANU over 4 years ago. Updated about 1 year ago.

Status:
New
Priority:
Normal
Category:
Text formatting
Resolution:

Description

This is related to #35892.

The sanitisation rules should allow footnotes markup to render as they are generated by commonmark gem for easier customisations.


Files

footnotes.png (232 KB) footnotes.png Marius BĂLTEANU, 2022-05-31 08:32

Updated by Holger Just over 4 years ago Actions #1

Is this resolved with r21612 already or are there any further required steps?

Updated by Marius BĂLTEANU over 4 years ago Actions #2

This is how it looks without SanitizationFilter:

And I think it is useful to have the data-footnote-* attributes, the class and even the section element. I've already some working code to obtain this.

What do you think?

Updated by Holger Just over 4 years ago Actions #3

I'm not opposed to this :)

I'm not sure the data attributes are required for us, given that we don't have anything in Redmine which wants this (specifically: no browser JS leveraging those attributes).

The aria-label and class attributes are probably useful though, as might be the section.

Updated by Go MAEDA about 3 years ago Actions #4

  • Target version changed from 5.1.0 to 6.0.0

Updated by Marius BĂLTEANU about 2 years ago Actions #5

  • Target version changed from 6.0.0 to 6.1.0

Updated by Marius BĂLTEANU about 1 year ago Actions #6

  • Target version changed from 6.1.0 to Candidate for next major release
Actions

Also available in: PDF Atom