Project

General

Profile

Actions
Copy link

Feature #37621

closed

Add field separator option to CSV export dialog

Added by Karel Pičman over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Issues
Target version:
5.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

I would like to add a field separator option to the CVS export option form.

Background:

If I have set the language e.g. to English in my Redmine profile, the separator is taken from config/locales/en.yml (general_csv_separator) and it is comma. If I have installed e.g. German Microsoft Office and try to open such a CSV, it expects that the separator is semicolon. Unfortunately, Microsoft Office doesn't offer to choose the separator prior opening a CSV file and always uses the default value.

It is also related to #37581, where many translations have set general_csv_separator to different value than is expected in Microsoft Office.

Files

Download all files
field_separator_in_csv_export_options.patch (7.46 KB) field_separator_in_csv_export_options.patch Karel Pičman, 2022-08-30 09:37
field_separator_export_option.png (24.4 KB) field_separator_export_option.png Karel Pičman, 2022-08-30 09:50
clipboard-202310211526-mpvaq.png (92.5 KB) clipboard-202310211526-mpvaq.png Go MAEDA, 2023-10-21 08:26
Actions
Copy link
 #1

Updated by Go MAEDA over 2 years ago

Is the ability to select decimal separator unnecessary?

I think you need to change the decimal separator to ";" when you change the field separator to ",".

Actions
Copy link
 #2

Updated by Karel Pičman over 2 years ago

No, you needn't. When the decimal separator is comma, values containing comma are enclosed in apostrophes.

...2022-09-12,"","2,50","2,50",0,2022-09-12 07:37...

Actions
Copy link
 #3

Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release
Actions
Copy link
 #4

Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 5.1.0

Setting the target version to 5.1.0.

Actions
Copy link
 #5

Updated by Go MAEDA over 1 year ago

Committed the patch in r22359 with the following changes.

  • Removed ":", "{tab}", "{space}" from the field separator options because the current importer does not support them. But I think "{tab}" is useful, so I opened a new issue #39212
  • Changed the text in the select box from "," and ";" to "Comma" and "Semicolon", the same as the importer's dialog
  • Added more tests

Thank you for your contribution.

Actions
Copy link
 #6

Updated by Mischa The Evil over 1 year ago

Go MAEDA wrote in #note-5:

  • Removed ":", "{tab}", "{space}" from the field separator options because the current importer does not support them. [...]

While I don't care about this change particularly, I do strongly think that Redmine's CSV-import capabilities shouldn't be leading in setting the scope for the CSV-export capabilities. I believe that Redmine should be agnostic about any post-processors of the exported CSV file.

Actions
Copy link
 #7

Updated by Go MAEDA over 1 year ago

  • Tracker changed from Patch to Feature
  • Resolution set to Fixed
Actions
Copy link

Also available in: Atom PDF