Redmine

I think the problem (or "code smell") is that the case argument is object.class.name and not object. If the code was like this, using Fixnum would be fine because Fixnum equals Integer:

case object
when Array
  formatted_objects = object.map {|o| format_object(o, html)}
  html ? safe_join(formatted_objects, ', ') : formatted_objects.join(', ')
when Time
  format_time(object)
when Date
  format_date(object)
when Fixnum
  object.to_s
when Float
  sprintf "%.2f", object

I agree with the use of Integer instead of Fixnum.

However, I don't think the patch works, because the case expression is object.class, but it should be object.

The case statement calls === on the expression(s) that come after when, with the case expression as a parameter.

>> object = 1
=> 1
>> Integer === object        # Integer.===(object)
=> true
>> Integer === object.class  # Integer.===(object.class)
=> false