Project

General

Profile

Actions

Defect #38210

closed

Incorrect DB migration version

Added by Mischa The Evil about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Database
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

r22038 added the 20221214173537_add_select_project_publicity_permission.rb migration file. However, it is versioned as a Rails/AR 5.2 migration while at the time of the commit the trunk was already on Rails 6.1.

I'm not sure if this was done for a specific purpose nor if changing this retroactively will cause other issues. But I thought it would at least be good to report it here as such.


Related issues

Related to Redmine - Feature #38048: Introduce permission to set a project publicClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA about 1 year ago

Thank you for pointing this out. This was my mistake and I should have changed the version to 6.1 before committing.

I think it is safe to change source:trunk/db/migrate/20221214173537_add_select_project_publicity_permission.rb to update the version from 5.2 to 6.1 because the code in the migration is a simple Rails code and the behavior does not change depending on the version of Migration.

Actions #2

Updated by Holger Just about 1 year ago

  • Related to Feature #38048: Introduce permission to set a project public added
Actions #3

Updated by Holger Just about 1 year ago

Yeah, just updating this will probably be fine as there is no DDL involved in the migration (and even then, it would likely be okay).

Actions #4

Updated by Go MAEDA about 1 year ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Fixed the migration version. Thank you.

Actions

Also available in: Atom PDF