Project

General

Profile

Actions
Copy link

Feature #38273

closed

Improve errors in MailHandler: add MissingContainer and LockedTopic exception

Added by Felix Schäfer over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Email receiving
Target version:
5.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

There are some cases for which the MailHandler drops incoming emails and just logs an info. This patch replaces this with a custom error to allow for plugins to more easily hook into those unhandled cases. This also unifies the logged message and the error handling in MailHandler.

Files

Download all files
1-missing_container_error.patch (1.92 KB) 1-missing_container_error.patch Felix Schäfer, 2023-02-13 15:40
2-locked_topic_error.patch (859 Bytes) 2-locked_topic_error.patch Felix Schäfer, 2023-02-13 15:40

Related issues

Blocks Redmine - Feature #38274: Receive e-mail replies to news and news commentsClosedGo MAEDA

Actions
Blocked by Redmine - Feature #38263: Try importing journal replies as issue reply where applicableClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Felix Schäfer over 2 years ago

The attached patch adds a custom generic Error for cases when the replied to object/the container object cannot be found, either because it was deleted or because the e-mail comes from another Redmine installation with different IDs. The second patch adds a custom Error for cases where the topic the e-mail answers to is locked.

Actions
Copy link
 #2

Updated by Holger Just over 2 years ago

  • Blocks Feature #38274: Receive e-mail replies to news and news comments added
Actions
Copy link
 #3

Updated by Go MAEDA over 2 years ago

  • Target version set to 5.1.0

Setting the target version to 5.1.0.

Actions
Copy link
 #4

Updated by Go MAEDA over 2 years ago

  • File 1-missing_container_error-v2.patch added

Updated the first patch to apply cleanly to the current trunk.

Actions
Copy link
 #5

Updated by Go MAEDA over 2 years ago

Go MAEDA wrote:

Updated the first patch to apply cleanly to the current trunk.

I am withdrawing this patch. 1-missing_container_error.patch can be applied without problems if #38263 is applied.

Actions
Copy link
 #6

Updated by Go MAEDA over 2 years ago

  • File deleted (1-missing_container_error-v2.patch)
Actions
Copy link
 #7

Updated by Go MAEDA over 2 years ago

  • Blocked by Feature #38263: Try importing journal replies as issue reply where applicable added
Actions
Copy link
 #8

Updated by Go MAEDA over 2 years ago

  • Subject changed from Improve errors in MailHandler to Improve errors in MailHandler: add MissingContainer and LockedTopic exception
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patches. Thank you.

Actions
Copy link

Also available in: Atom PDF