Project

General

Profile

Actions

Defect #38493

closed

The related issues count on the issue view is not updated after deleting one of the related issues

Added by Takashi Kato 11 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

Attached is a patch to fix it.

(Off topic, but the Affected Version list on the issue submission view does not seem to have been updated).


Files

Actions #1

Updated by Go MAEDA 11 months ago

  • Status changed from New to Confirmed
  • Target version set to Candidate for next major release
Actions #2

Updated by Go MAEDA 11 months ago

  • Target version changed from Candidate for next major release to 5.1.0

Setting the target version to 5.1.0.

Actions #3

Updated by Go MAEDA 11 months ago

  • Target version changed from 5.1.0 to Candidate for next major release

The patch breaks some tests:

Failure:
IssueRelationsControllerTest#test_destroy_xhr [/Users/maeda/redmines/redmine-trunk/test/functional/issue_relations_controller_test.rb:318]:
Expected response to be a <2XX: success>, but was a <404: Not Found>
Response body: <h2>404</h2>

  <p id="errorExplanation">The page you were trying to access doesn&#39;t exist or has been removed.</p>

<p><a href="javascript:history.back()">Back</a></p>

rails test test/functional/issue_relations_controller_test.rb:312
Failure:
IssueRelationsControllerTest#test_destroy [/Users/maeda/redmines/redmine-trunk/test/functional/issue_relations_controller_test.rb:300]:
"IssueRelation.count" didn't change by -1.
Expected: 1
  Actual: 2

rails test test/functional/issue_relations_controller_test.rb:299
Failure:
Redmine::ApiTest::IssueRelationsTest#test_DELETE_/relations/:id.xml_should_delete_the_relation [/Users/maeda/redmines/redmine-trunk/test/integration/api_test/issue_relations_test.rb:103]:
"IssueRelation.count" didn't change by -1.
Expected: 1
  Actual: 2

rails test test/integration/api_test/issue_relations_test.rb:102
Actions #5

Updated by Mischa The Evil 5 months ago

  • Assignee set to Go MAEDA

Takashi Kato wrote in #note-4:

Sorry, the fixed patch is available

Thanks! Given the previous scheduling, I think that it would be nice if this could still be included in 5.1.0 now that the patch has been updated/fixed.

Go MAEDA: would you mind to look into this and commit it if it's functioning properly?

Actions #6

Updated by Mischa The Evil 5 months ago

  • Target version changed from Candidate for next major release to 5.1.0
Actions #7

Updated by Go MAEDA 5 months ago

  • Subject changed from When deleting a related issue on the issue view, the related issue count is not updated to The related issues count on the issue view is not updated after deleting one of the related issues
  • Status changed from Confirmed to Closed

Committed the fix in r22395 and merged to the 5.1-stable branch. Thank you all for your contribution.

Actions #8

Updated by Mischa The Evil 5 months ago

  • Status changed from Closed to Reopened

Go MAEDA wrote in #note-7:

Committed the fix in r22395 and merged to the 5.1-stable branch.

It seems the merge to 5.1-stable hasn't happened yet.

Actions #9

Updated by Go MAEDA 5 months ago

  • Status changed from Reopened to Closed

Mischa The Evil wrote in #note-8:

Go MAEDA wrote in #note-7:

Committed the fix in r22395 and merged to the 5.1-stable branch.

It seems the merge to 5.1-stable hasn't happened yet.

Done.

Actions

Also available in: Atom PDF