Actions
Defect #39778
closedUntranslated string "OK" in the repository browser
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Taken from Defect #38509#note-4: Untranslated string "OK" in the repository browser:
One another 'OK' missed in diff page.
Related issues
       Updated by Mischa The Evil almost 2 years ago
      Updated by Mischa The Evil almost 2 years ago
      
    
    - Related to Defect #38509: Untranslated string "OK" in the repository browser added
       Updated by Mischa The Evil almost 2 years ago
      Updated by Mischa The Evil almost 2 years ago
      
    
    Off-topic:
Mischa The Evil wrote:
Defect #38509#note-4: Untranslated string "OK" in the repository browser:
Woot! This syntax actually works... Neat! Thumbs up to Jens Krämer et al.
       Updated by Go MAEDA about 1 year ago
      Updated by Go MAEDA about 1 year ago
      
    
    - Target version set to 5.1.4
Thank you for pointing out. I had to include the following change in r22231.
diff --git a/app/views/repositories/diff.html.erb b/app/views/repositories/diff.html.erb
index 3551c38c4..8af09e70e 100644
--- a/app/views/repositories/diff.html.erb
+++ b/app/views/repositories/diff.html.erb
@@ -23,7 +23,7 @@
                :rev        => nil},
                :method     => :get) do %>
     <%= text_field_tag 'rev', @rev, :size => 8 %>
-    <%= submit_tag 'OK', :name => nil %>
+    <%= submit_tag l(:button_view), :name => nil %>
   <% end %>
 </div>
 <%= render :partial => 'changeset' %>
       Updated by Go MAEDA about 1 year ago
      Updated by Go MAEDA about 1 year ago
      
    
    - Status changed from New to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix in r22983.
       Updated by Go MAEDA about 1 year ago
      Updated by Go MAEDA about 1 year ago
      
    
    - Status changed from Resolved to Closed
Merged the fix to 5.1-stable branch.
Actions