Project

General

Profile

Actions
Copy link

Defect #40020

closed

ScmData.binary? incorrectly considers UTF-8 text as binary

Added by Go MAEDA 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
SCM
Target version:
6.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Currently, the binary? method in Redmine::Scm::Adapters::ScmData often misclassifies Unicode text as binary. This is because the method actually checks whether the given data is ASCII text or not.

The new implementation in the attached patch checks for control characters excluding tabs, newlines, and carriage returns, and calculates their proportion in the data. It ensures accurate detection of binary data while properly handling Unicode text.

Files

Download all files
0001-Fix-ScmData.binary-method-not-to-consider-UTF-8-text.patch (2.96 KB) 0001-Fix-ScmData.binary-method-not-to-consider-UTF-8-text.patch Go MAEDA, 2024-01-08 15:57
0001-Fix-ScmData.binary-method-not-to-consider-UTF-8-text.patch (2.96 KB) 0001-Fix-ScmData.binary-method-not-to-consider-UTF-8-text.patch Go MAEDA, 2024-01-09 05:53
Actions
Copy link

Also available in: Atom PDF