Actions
Patch #42756
closedUpdate tests for rails-dom-testing 2.3.0 whitespace collapsing
Description
rails-dom-testing 2.3.0 and later collapse whitespace in assert_select :text , causing some tests to fail if they expect multiple spaces or tabs.
https://github.com/hidakatsuya/redmine/actions/runs/15154438331/job/42621433335
Failure: IssuesControllerTest#test_index_with_last_notes_column [test/functional/issues_controller_test.rb:1738]: --- expected +++ actual @@ -1 +1 @@ -"A comment with inline image: and a reference to #1 and r2." +"A comment with inline image: and a reference to #1 and r2." . Expected 0 to be >= 1. bin/rails test test/functional/issues_controller_test.rb:1725 ...
This patch updates the affected tests to expect collapsed whitespace.
It also sets the minimum required version of rails-dom-testing to 2.3.0, since the updated tests fail on earlier versions.
Confirmed that the tests pass on both master and 5.1-stable.
Files
Updated by Katsuya HIDAKA 2 days ago
Currently, all GitHub CI jobs are failing. I believe this patch will fix the issue.
https://github.com/redmine/redmine/actions/runs/15197996337/job/42746539012
Actions