Patch #42847
openImprove clarity of mail option labels in en.yml
0%
Description
This patch improves the clarity and naturalness of three user mail option labels in `config/locales/en.yml`.
Modified strings:
- `label_user_mail_option_only_my_events`
- `label_user_mail_option_only_assigned`
- `label_user_mail_option_only_owner`
The updated phrasing uses "I am watching" instead of "I watch" for consistency with other parts of the UI, and replaces "I am the owner of" with the more natural "created by me".
Before:
- Only for things I watch or I'm involved in
- Only for things I watch or I am assigned to
- Only for things I watch or I am the owner of
After:
- Only for things I am watching or involved in
- Only for things I am watching or assigned to
- Only for things I am watching or created by me
Patch file is attached.
Files
Updated by Holger Just 1 day ago
I'm not sure if this is an actual improvement. I'm not a native English speaker either, but the proposed translations sound less natural then the previous ones.
- "I'm watching" or "I watch" is more or less the same here. I have no real preference.
- "...I am watching or involved in" - here, the "am" would have to be repeated for the second part, i.e. "...I am watching or am involved in". Skipping the second "am" feels wrong. Then however, we would repeat the I am" two times in the same short sentence, which again sounds weird. Here, I think the best option is still to retain the previous structure, i.e. "... I watch or I'm involved in".
- I think the general rule for contracting "I am" to "I'm" is that it's (1) used informally) and (2) is only allowed when used with with a phrase noun (e.g. "I'm assigned", "I'm watching"). I think excludes the "I'm assigned to" case as "assigned to" is not a phrase noun.
With that being said, it is definitely a good idea to clarify the terms "involved in" and "owner of" which are not used anywhere else. Maybe the following would be more appropriate?
label_user_mail_option_only_my_events: "Only for things I'm watching, I created or which I am assigned to" label_user_mail_option_only_assigned: "Only for things I'm watching or which I am assigned to" label_user_mail_option_only_owner: "Only for things I'm watching or which I created"
We could debate about using an Oxford comma in the translation for label_user_mail_option_only_my_events
. Prior usage in Redmine does not use one, although personally I'm a fan of it in general :) As for generally removing the use of "I'm" in favor of "I am", I could also work with that. We do not have any other use of I'm / I am anywhere else. I think the contraction would still work here though, although it it less formal English.
As for the assigned cases: technically we send notifications for all of the following cases here:
- if the user (or one of their groups) is the unchanged assignee
- if the user (or one of their groups) is selected as the new assignee
- if the user (or one of their groups) was the previous assignee and someone has just selected a different (or no) assignee
The possible phrase "I am or was assigned to" would be wrong here as it would imply that a notification is sent if the user was an assignee at any time in the past rather than only just before the current change. As such, I believe this can be legitimately summarized as "I am assigned to" without having to fully explain the exact rules for the previous assignee in the option title.
Finally, some other notification options use the term "any event" / "no event" rather than "thing". While this term is technically correct there, it may be surprising or unclear to people who are not aware of the underlying implementation. It may be a good idea to unify all of the notification options to use the same terms, i.e. either "things" or "events", or even something like "For any event on things I'm watching ..."
In the German translation, the term "Ereignis" / "Änderung" (from English "event" / "change") is used inconsistently in a similar manner. This could be clarified / cleaned up once we have decided on a common English translation.
What do you think?