Redmine

Would it be acceptable if in the patch we replaced self.class.method_defined?(method_name) with self.class.private_method_defined?(method_name) ?

I tried to run the test but I only have the production environment and got the error "The `test` database is not configured for the `test` environment".

Vincent Caron wrote in #note-3:

Would it be acceptable if in the patch we replaced self.class.method_defined?(method_name) with self.class.private_method_defined?(method_name) ?

That would still be wrong as this would check if there is a private class method, rather than an instance method. However, a cleaner version with equivalent functionality would be this:

--- app/models/mail_handler.rb.orig    2025-03-11 00:30:03.000000000 +0100
+++ app/models/mail_handler.rb    2025-09-26 18:42:40.504660223 +0200
@@ -155,7 +155,7 @@
     if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
       klass, object_id = $1, $2.to_i
       method_name = "receive_#{klass}_reply" 
-      if self.class.private_instance_methods.collect(&:to_s).include?(method_name)
+      if respond_to?(method_name, true)
         send method_name, object_id
       else
         # ignoring it

Here, we allow any visibility of the respective receive method, i.e. public, protected or private. To quote the documentation of Object#respond_to?:

Returns true if obj responds to the given method. Private and protected methods are included in the search only if the optional second parameter evaluates to true.

I've tested Holger Just's patch and it works fine for me (ie. compatible with a plugin which monkey patches MailHandler).