Redmine

Even when the Time span format is set to a decimal style (`0.75`), Redmine still accepts input in the h:mm format. Because of this, I think it is acceptable to keep the placeholder fixed as h:mm.

Go MAEDA wrote in #note-1:

Even when the Time span format is set to a decimal style (`0.75`), Redmine still accepts input in the h:mm format. Because of this, I think it is acceptable to keep the placeholder fixed as h:mm.

I understand that input in the h:mm format is supported. However, I usually use the 0.75 format, and the difference between the display format and the edit format can be a bit confusing for users.

To improve clarity and consistency, could the placeholder reflect the selected time span format?
For example: e.g., h:mm or 0.75

I propose the following change to the placeholder behavior.

In the following patch, the "h:mm" placeholder is shown only when the "Time span format" is set to "minutes".
If the "Time span format" is set to "decimal", no placeholder is shown.

I am not sure what placeholder would be appropriate when the format is "decimal". In addition, the placeholder logic would become a bit complicated because it would need to handle internationalized decimal separators ('.' and ',').

diff --git a/lib/redmine/views/labelled_form_builder.rb b/lib/redmine/views/labelled_form_builder.rb
index c08030d93..951dcbca7 100644
--- a/lib/redmine/views/labelled_form_builder.rb
+++ b/lib/redmine/views/labelled_form_builder.rb
@@ -49,7 +49,7 @@ class Redmine::Views::LabelledFormBuilder < ActionView::Helpers::FormBuilder
     # display the value before type cast when the entered value is not valid
     if @object.errors[field].blank?
       options = options.merge(:value => format_hours(@object.send field))
-                       .with_defaults(:placeholder => 'h:mm')
+                       .with_defaults(:placeholder => Setting.timespan_format == 'minutes' ? 'h:mm' : '')
     end
     text_field field, options
   end

What about showing the same value from administration setting, but localized?

diff --git a/lib/redmine/views/labelled_form_builder.rb b/lib/redmine/views/labelled_form_builder.rb
index c08030d93..d89b86277 100644
--- a/lib/redmine/views/labelled_form_builder.rb
+++ b/lib/redmine/views/labelled_form_builder.rb
@@ -48,8 +48,10 @@ class Redmine::Views::LabelledFormBuilder < ActionView::Helpers::FormBuilder
   def hours_field(field, options={})
     # display the value before type cast when the entered value is not valid
     if @object.errors[field].blank?
+      placeholder = (Setting.timespan_format == 'minutes' ? 'h:mm' : number_with_delimiter(0.75))
+
       options = options.merge(:value => format_hours(@object.send field))
-                       .with_defaults(:placeholder => 'h:mm')
+                       .with_defaults(:placeholder => placeholder)
     end
     text_field field, options
   end

Marius BĂLTEANU wrote in #note-4:

What about showing the same value from administration setting, but localized?

The purpose of the placeholder added in #2464 is to indicate one of the expected time formats other than non-decimal values. Therefore, in my opinion, displaying a placeholder such as "0.75" is inappropriate. Moreover, I am concerned that showing a specific numeric value may confuse users.

Go MAEDA
Thank you for your support as always.