Project

General

Profile

Actions

Feature #43836

closed

Unify spacing around section separators on issue details page

Added by Go MAEDA 21 days ago. Updated 9 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Resolution:
Fixed

Description

On the issue details page, spacing around section separators is inconsistent (for example between Description, Subtasks, and Related issues).

A likely reason is that `hr` does not define vertical spacing. As a result, spacing is affected by surrounding elements' default margins and looks uneven depending on the section.

I propose using a single vertical spacing rule for these separators to make the layout cleaner.

diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 9ab5aa695..601bbbf0c 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -780,6 +780,7 @@ div.issue .attribute .value {overflow:auto; text-overflow: ellipsis;}
 div.issue .attribute.string_cf .value .wiki p {margin-block: 0;}
 div.issue .attribute.text_cf .value .wiki p:first-of-type {margin-block-start: 0;}
 div.issue.overdue .due-date .value { color: var(--oc-red-9); }
+div.issue.details > hr { margin-block: 16px; }
 body.controller-issues h2.inline-flex {padding-inline-end: 0}
 div#sticky-issue-header {
   display: none;
Actions #1

Updated by Marius BĂLTEANU 21 days ago

Nice!

Can we also consider to change the style of hr to something else? I really like the solution from Plan.io with white space, but I think we need their approval for such a change. For sure I'm quite biassed because I'm not a huge fan of borders everywhere.

Actions #2

Updated by Marius BĂLTEANU 21 days ago

Marius BĂLTEANU wrote in #note-1:

Can we also consider to change the style of hr to something else? I really like the solution from Plan.io with white space, but I think we need their approval for such a change. For sure I'm quite biassed because I'm not a huge fan of borders everywhere.

I think it is better to postpone this for a broader discussion regarding a modern UI.

Actions #3

Updated by Go MAEDA 16 days ago

Marius BĂLTEANU wrote in #note-2:

Marius BĂLTEANU wrote in #note-1:

Can we also consider to change the style of hr to something else? I really like the solution from Plan.io with white space, but I think we need their approval for such a change. For sure I'm quite biassed because I'm not a huge fan of borders everywhere.

I think it is better to postpone this for a broader discussion regarding a modern UI.

Yes, the suggested change to divide the div#issue area into three parts is controversial, so I would like the discussion to be separated from this issue.

Actions #4

Updated by Go MAEDA 12 days ago

  • Target version changed from Candidate for next major release to 7.0.0

Setting the target version to 7.0.0.

Actions #5

Updated by Go MAEDA 9 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch in r24472.

Actions

Also available in: Atom PDF