Project

General

Profile

Actions

Feature #43959

open

add wikitoolbar on custom field on other types than issue

Added by Brice Beaumesnil 6 months ago. Updated 18 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Custom fields
Target version:
Resolution:

Description

Hello,

If we add long text custom field with text formatting on version for example : no wikitoolbar appear.
In this case, the line
<%= wikitoolbar_for "version_custom_field_values_#{value.custom_field_id}" if value.custom_field.full_text_formatting? %>
can be add on the customfield loop in the file app/views/versions/_form.html.erb

best regards


Files


Related issues

Related to Redmine - Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabledClosedGo MAEDAActions
Actions #1

Updated by Go MAEDA 6 months ago

Thank you for posting the patch. I added tests for the patch.

Actions #2

Updated by Go MAEDA 6 months ago

  • Target version changed from Candidate for next major release to 7.0.0

Setting the target version to 7.0.0.

Actions #3

Updated by Go MAEDA 6 months ago

  • Target version changed from 7.0.0 to Candidate for next major release

I will also add a toolbar to the long text custom fields for the following types of objects:

  • Spent time
  • Projects
  • Time tracking activities

However, I will not add a toolbar to custom fields for users, because the area where the custom field textarea is displayed is narrow and does not have sufficient width to show the toolbar.

Actions #4

Updated by Go MAEDA 21 days ago

  • Related to Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled added
Actions #5

Updated by Go MAEDA 21 days ago

The attached patch adds the wiki toolbar to long text custom fields with text formatting enabled on the following forms:

  • Versions
  • Projects
  • Enumerations (time tracking activities, issue priorities and document categories)
  • Documents
  • Groups
  • Spent time fields in the issue edit form

Issues and the spent time form are not changed because they already have the toolbar (see #33256 for the spent time form). There are also some cases where the toolbar is not added:

  • User custom fields: the area for the custom fields is too narrow for the toolbar.
  • The "Time tracking" tab in project settings: the custom fields are displayed in table cells.
  • The "New version" modal opened from the issue form: the CSS for the toolbar tabs only applies inside #content, so the toolbar is not displayed correctly in the modal.
Actions #6

Updated by Go MAEDA 18 days ago

  • Target version changed from Candidate for next major release to 7.1.0

Setting the target version to 7.1.0.

Actions

Also available in: Atom PDF