Project

General

Profile

Actions

Patch #44074

closed

ignored and unnecessary scope in twofa token lookup

Added by Jens Krämer 21 days ago. Updated 20 days ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:

Description

When deleting the used twofa backup code there is this line:

Token.where(user_id: @user.id).find_token('twofa_backup_code', code).try(:delete)

Token.find_token however doesn't honor the prepended relation, and also we do check the user
in the next line so the patch simply removes the where(...) part.


Files

Actions #1

Updated by Go MAEDA 21 days ago

  • Target version set to Candidate for next major release
Actions #2

Updated by Marius BĂLTEANU 20 days ago

  • Status changed from New to Closed
  • Assignee set to Marius BĂLTEANU
  • Target version changed from Candidate for next major release to 7.0.0

Committed, thanks!

Actions

Also available in: Atom PDF