Defect #44273
closed
Applications item is not highlighted in the administration menu
Added by Liane Hampe about 1 month ago.
Updated 12 days ago.
Description
The admin menu does not highlight the current menu item in sidebar when the admin user is on the Outh2 Application page. This patch adds the menu item highlight.
Before:
After:
A patch is provided based on RM 6.1.3.
Files
- Tracker changed from Patch to Defect
- Status changed from New to Confirmed
- Target version set to Candidate for next minor release
Thank you for reporting this and for the patch.
I made two changes to the patch:
- Removed
include Redmine::MenuManager::MenuController from Oauth2ApplicationsController. ApplicationController already includes it, so menu_item is available through inheritance.
- Added an assertion to the existing system test in
test/system/oauth_provider_test.rb
Setting the target version to 6.1.4.
- Subject changed from Add menu item highlighting on oauth application controller to Applications item is not highlighted in the administration menu
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix in r24903. Thank you for catching and fixing the issue.
- Status changed from Resolved to Closed
Merged the fix into the stable branches in r24920 and r24922.
Also available in: Atom
PDF
Updated by