Project

General

Profile

Actions
Copy link

Patch #44386

closed

Avoid N+1 queries generated by Webhook#setable_projects

Added by Marius BĂLTEANU about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Performance
Target version:
7.0.2

Description

Extracted from #44337:

Vincent Robert wrote:

The patch also resolves a performance issue by changing one line in Webhook#setable_projects (N+1 queries when filtering lots of projects)

Related issues

Related to Redmine - Feature #44337: Add an administration page listing all webhooksClosedMarius BĂLTEANUActions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU about 1 month ago

  • Status changed from New to Resolved

Committed the performance fix, thanks!

Actions
Copy link
 #2

Updated by Marius BĂLTEANU about 1 month ago

Holger Just wrote in #note-9:

We should also drop the to_a there. Instead, in the before_validation hook we could just pluck the IDs and compare it to the ids of the hook's proposed projects.

Committed this change in r25011.

Actions
Copy link
 #3

Updated by Marius BĂLTEANU about 1 month ago

  • Related to Feature #44337: Add an administration page listing all webhooks added
Actions
Copy link
 #4

Updated by Holger Just about 1 month ago

Thank you!

Actions
Copy link
 #5

Updated by Marius BĂLTEANU about 1 month ago

  • Status changed from Resolved to Closed

Merged to 7.0-stable branch.

Actions
Copy link

Also available in: Atom PDF