Defect #44488
closed
Info text for "Initials" fallback avatars shows Gravatar URL even when a custom avatar_server_url is configured
Description
Setting Settings > Display > Default Gravatar image to Initials displays the info tip "Users' initials are sent to https://www.gravatar.com to generate their avatars." which is correct.
However if the user has set a different Gravatar server url in config/configuration.yml, this tip is unchanged.
The url value is correctly updated in the info tip under Use Gravatar user icons but never for the Initials info tip.
The behaviour has been confirmerd, the Initials are also requested from the config set avatar service url.
This is a small cosmetic bug, but it raised some red flags in my company as it made it seem that our intranet Redmine was sending requests to an external service.
Files
Related issues
Updated by Go MAEDA 20 days ago
- Related to Feature #42623: Adds initials to the list of default Gravatar options added
- Related to Feature #9112: Libravatar and Gravatar-compatible servers support added
Updated by Go MAEDA 20 days ago
- File 0001-Fix-info-text-for-Initials-fallback-avatars-ignoring.patch added
- Subject changed from Incorrect information text when fallback avatars are set to "Initials" to Info text for "Initials" fallback avatars shows Gravatar URL even when a custom avatar_server_url is configured
- Target version set to 6.1.5
The attached patch fixes the issue by embedding the value of avatar_server_url from config/configuration.yml in the text, instead of hard-coding https://www.gravatar.com. When avatar_server_url is not set, the text remains unchanged because the default value is https://www.gravatar.com.
Updated by Go MAEDA 19 days ago
- File 0001-Fix-info-text-for-Initials-fallback-avatars-ignoring.patch 0001-Fix-info-text-for-Initials-fallback-avatars-ignoring.patch added
- File deleted (
0001-Fix-info-text-for-Initials-fallback-avatars-ignoring.patch)