Redmine

The tests for Propshaft::Assembly#manifest_outdated? and #needs_precompile? in test/unit/initializers/patches_test.rb, added in #44240, fail intermittently when the tests are run with multiple workers, such as PARALLEL_WORKERS=8 bin/rails test:

Errno::ENOENT: No such file or directory @ rb_sysopen - /path/to/redmine/public/assets/.manifest.json
    config/initializers/10-patches.rb:150:in 'Pathname#read'
    config/initializers/10-patches.rb:150:in 'manifest_outdated?'

The cause is that these tests temporarily overwrite and delete the actual manifest file, public/assets/.manifest.json, which is shared by all workers. As a result, a worker can fail when another worker deletes the file just before it is read, and a stale or invalid manifest can be left behind after the run.

The attached patch makes the tests point Rails.application.assets.config.manifest_path to a file in a temporary directory and restore the original value afterwards. The tested methods read config.manifest_path on every call, so they are still exercised in the same way. Only the test file is changed.

With PARALLEL_WORKERS=8, running PatchesTest together with other tests failed in every attempt without the patch, and passed in every attempt with it.