Project

General

Profile

Actions

Defect #6612

closed

SortHelper missing from CalendarsController

Added by Felix Schäfer about 14 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Calendar
Target version:
Start date:
2010-10-08
Due date:
% Done:

100%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I just tried to show a calendar with a custom query, so something like: http://my.redmi.ne/issues/calendar?query_id=13, which causes redmine to quit on a:

NameError (undefined local variable or method `sort_clear' for #<CalendarsController:0x7f4400887b10>):
  app/helpers/queries_helper.rb:75:in `retrieve_query'
  app/controllers/calendars_controller.rb:23:in `show'

The solution is to include SortHelper in CalendarsController.

Actions #1

Updated by Eric Davis about 14 years ago

  • Target version set to 1.0.3

Thanks, I'll fix that.

Actions #2

Updated by Eric Davis about 14 years ago

  • Category set to Calendar
  • Status changed from New to Resolved
  • % Done changed from 0 to 100
  • Resolution set to Fixed

Fixed in r4245 and added a test case.

Actions #3

Updated by Mischa The Evil about 14 years ago

Eric Davis wrote:

  • Target version set to 1.0.3

Shouldn't this be targetted to 1.1.0?

Actions #4

Updated by Eric Davis about 14 years ago

Mischa The Evil wrote:

Shouldn't this be targetted to 1.1.0?

No, CalendarsController was refactored in the 1.0.x branch too.

Actions #5

Updated by Mischa The Evil about 14 years ago

Eric Davis wrote:

Mischa The Evil wrote:

Shouldn't this be targetted to 1.1.0?

No, CalendarsController was refactored in the 1.0.x branch too.

ACK ;)

Actions #6

Updated by Eric Davis almost 14 years ago

  • Status changed from Resolved to Closed

Merged into 1.0-stable for release in 1.0.3

Actions

Also available in: Atom PDF