Project

General

Profile

Actions

Patch #7086

open

Few fixes for subversion

Added by Dmitry Salashnik over 13 years ago. Updated over 13 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2010-12-09
Due date:
% Done:

0%

Estimated time:

Description

  • not works when svn server use self signed certificate
  • No read access file breaks file listing when browsing repository
  • fetch not all changesets

Files

subversion_adapter.diff (1.9 KB) subversion_adapter.diff Dmitry Salashnik, 2010-12-09 11:11

Related issues

Related to Redmine - Defect #18754: empty svn logentry crashes revision batch readingNew

Actions
Actions #1

Updated by Mischa The Evil over 13 years ago

  • Category set to SCM
Actions #2

Updated by Jean-Baptiste Barth over 13 years ago

I understand the last two modifications of the file, but not the first two ones. Can you explain a bit your patch and, if possible, provide some unit tests with it (not for the certificate part, but the things you mention may be testable).

Actions #3

Updated by Dmitry Salashnik over 13 years ago

  1. Skip directory ANY ITEM if there is no commit date (usually that that we don't have read access to it).
    In my reposity exists not readable files for redmine. without this patch directory listing breaks on this file
                     # Skip directory if there is no commit date (usually that
                     # means that we don't have read access to it)
    -                next if entry['kind'] == 'dir' && commit_date.nil?
    +#                next if entry['kind'] == 'dir' && commit_date.nil?
    +                next if commit_date.nil?
    
  2. I don't know why, but sometimes logentry['msg'] = nil and redmine crashes on this revision and it not appears into redmine's revisions listing :(
    -                              :message => logentry['msg']['__content__'],
    +                              :message => (logentry['msg'] ? logentry['msg']['__content__'] : ""),
    
  3. Simply debugging code, i want know what happens when crashed :)
    -            rescue
    +              rescue Exception => e
    +                logger.error "ERROR: #{ e.message}" 
    
  4. Allow working with self-signed cert
    -          str << " --no-auth-cache --non-interactive" 
    +          str << " --no-auth-cache --non-interactive --trust-server-cert" 
    
Actions #4

Updated by Dmitry Salashnik over 13 years ago

Jean-Baptiste Barth wrote:

if possible, provide some unit tests with it (not for the certificate part, but the things you mention may be testable).

I'm sorry, but i'm too newbie in ruby :(

Actions #5

Updated by Toshi MARUYAMA about 6 years ago

  • Related to Defect #18754: empty svn logentry crashes revision batch reading added
Actions

Also available in: Atom PDF