Project

General

Profile

Actions

Defect #7505

closed

Subversion: Repository URL with space not handled correctly

Added by Adam Piotr ┼╗ochowski about 13 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2011-01-31
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

To avoid issues with any special characters in URL I use Tortoise svn and it's " copy url link " option while browing repository. So Redmine gets nice clean proper URLs:

https://server/projects/Project%20Name

However, new Redmine now is munging clean URLs. For example the above URL gets parsed as:

https://server/projects/Project%2520Name

as far as I can guess, the URL is meant to be escaped, however lib\redmine\scm\adapters\subversion_adapter.rb is doing too much of replacing :

        def target(path = '')
          base = path.match(/^\//) ? root_url : url
          uri = "#{base}/#{path}" 
          uri = URI.escape(URI.escape(uri), '[]')
          shell_quote(uri.gsub(/[?<>\*]/, ''))
        end

This code is escaping too much. If URL is properly entered (and it should be) then no need to escape it again.

This is a regression from 0.9 series that worked ok with URLs.


Related issues

Related to Redmine - Defect #5461: Cannot browse SVN Repositories with whitespaces in themClosed2010-05-07

Actions
Related to Redmine - Defect #2532: Cannot browse Subversion paths that contain spacesClosedJean-Philippe Lang2009-01-19

Actions
Related to Redmine - Defect #17882: Subversion: French character filename causes error 404New

Actions
Related to Redmine - Defect #27043: SVN repos with spaces allow for browsing but not file viewingNew

Actions
Actions #1

Updated by Toshi MARUYAMA about 13 years ago

  • Subject changed from Repository URL not handled correctly to Subversion: Repository URL not handled correctly
Actions #2

Updated by Toshi MARUYAMA about 13 years ago

  • Subject changed from Subversion: Repository URL not handled correctly to Subversion: Repository URL with space not handled correctly
Actions #3

Updated by Toshi MARUYAMA over 9 years ago

  • Related to Defect #17882: Subversion: French character filename causes error 404 added
Actions #4

Updated by Go MAEDA over 7 years ago

  • Status changed from New to Closed

No problem in the current trunk (r16171).

Actions #5

Updated by Toshi MARUYAMA over 6 years ago

  • Related to Defect #27043: SVN repos with spaces allow for browsing but not file viewing added
Actions

Also available in: Atom PDF