Project

General

Profile

Actions

Patch #7770

closed

use unless in control structures where it improves readability

Added by Anonymous over 13 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
-
Start date:
2011-03-04
Due date:
% Done:

0%

Estimated time:

Description

Use unless or until in control structures instead of if ! or while ! where it improves readability.


Files

code_cleanup_ifnot_unless.diff (12.5 KB) code_cleanup_ifnot_unless.diff Anonymous, 2011-03-04 01:43
Actions #1

Updated by Jean-Baptiste Barth over 13 years ago

I think if blah.present? is easier to read than unless blah.blank? or if !blah.blank?, so we might switch to this in some cases you point out.

Actions #2

Updated by Anonymous over 13 years ago

yes that does makes more sense indeed. I looked it up here , present? is internally defined as !blank?

Actions #3

Updated by Go MAEDA about 1 month ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Fixed in r22987.

Actions

Also available in: Atom PDF