Feature #10264

Add a check/uncheck all button to search

Added by Jos Accapadi almost 8 years ago. Updated 9 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.0.2
Resolution:Fixed

Description

When getting search results, all items are checked. As more plugins are added, it extends the list of search items, where it would be good to have a clear all to just select the one or two that you want to search vs unchecking all.

search.png (40.2 KB) Mizuki ISHIKAWA, 2019-02-05 00:58

other2.png (12.7 KB) Mizuki ISHIKAWA, 2019-02-05 01:00

other1.png (28.6 KB) Mizuki ISHIKAWA, 2019-02-05 01:00

Associated revisions

Revision 17852
Added by Go MAEDA 10 months ago

Add a check/uncheck all button to search (#10264).

Patch by Mizuki ISHIKAWA.

Revision 17986
Added by Go MAEDA 9 months ago

Merged r17852 from trunk to 4.0-stable (#10264).

History

#1 Updated by Go MAEDA 10 months ago

  • Category set to UI

Probably we can fulfill this request by adding a green check icon ( ) to check/uncheck checkboxes, that can be seen in many pages such as Workflow and Permission report.

#2 Updated by Mizuki ISHIKAWA 10 months ago


By changing like this, a green check icon will be added.


On other screens, it is label + green check icon,
but I could not think of an appropriate label on this screen.

#3 Updated by Marius BALTEANU 10 months ago

  • Target version set to Candidate for next minor release

it is a small change and very useful, I propose to add it in a next minor release.

#4 Updated by Go MAEDA 10 months ago

  • Target version changed from Candidate for next minor release to 4.0.2

Marius BALTEANU wrote:

it is a small change and very useful, I propose to add it in a next minor release.

I agree. Setting the target version to 4.0.2.

#5 Updated by Go MAEDA 10 months ago

I changed the target version to 4.0.1, but this change may break themes for 4.0 because it changes the structure of HTML (wraps p#search-types with fieldset.box).

I think 4.1.0 is better.

#6 Updated by Go MAEDA 10 months ago

  • Subject changed from Add clear all to search to Add a check/uncheck all button to search
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thanks.

#7 Updated by Alexander Meindl 9 months ago

This issue shows target version 4.0.2 and changelog shows it, too. But the related commit currently only exists in trunk. I think, this issue should changed to target version 4.1.0 (as mentioned in #10264#note-5).

#8 Updated by Marius BALTEANU 9 months ago

Alexander Meindl wrote:

This issue shows target version 4.0.2 and changelog shows it, too. But the related commit currently only exists in trunk. I think, this issue should changed to target version 4.1.0 (as mentioned in #10264#note-5).

Indeed, the target version was never changed to 4.1.0. I'm not sure what we should do in this case, I see two options:
- we merge r17852 in 4.0-stable branch and deliver this feature in 4.0.3
- we change the target version to 4.1.0 and that's it.

#9 Updated by Marius BALTEANU 9 months ago

My recommendation is to deliver this in 4.0.3 (is not such a big change).

#10 Updated by Go MAEDA 9 months ago

Sorry for my mistake.

I have merged r17852 to 4.0-stable branch and it will be available in 4.0.3.

Also available in: Atom PDF