Feature #24577

Settings to make the issue and/or comment fields mandatory for time logs

Added by Marius BALTEANU about 1 year ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Time tracking
Target version:3.4.0
Resolution:Fixed

Description

The attached patch adds the following changes:
  1. a new tab in the application settings named "Time tracking"
  2. new settings to make the issue and/or comment fields mandatory for time logs. By default, the new settings are off in order to not change the current behaviour.
The patch implements the following tickets:

time_tracking_settings.png (44.1 KB) Marius BALTEANU, 2016-12-11 01:19

settings_to_make_issue_id_comment_fields_mandatory.patch Magnifier (4.56 KB) Marius BALTEANU, 2016-12-11 02:12

settings_to_make_issue_id_comment_fields_mandatory_v2.patch Magnifier (5.05 KB) Marius BALTEANU, 2016-12-11 02:21


Related issues

Related to Redmine - Defect #28110: Don't allow reassigning reported hours to the project if ... Closed
Duplicated by Redmine - Feature #4885: Option to make time log comments field mandatory Closed 2010-02-20
Duplicated by Redmine - Feature #12236: Option to make Comment field required Closed
Duplicated by Redmine - Feature #19813: Spent time comment mandatory Closed
Duplicated by Redmine - Defect #24049: Records in table time_entries with null value at field is... Closed
Duplicated by Redmine - Patch #2196: Do not save @time_entry if comment/hour is nil Closed 2008-11-15
Duplicated by Redmine - Feature #11039: Disable time tracking for projects Closed
Duplicated by Redmine - Feature #4690: Make it configurable to make the issue number mandatory w... Closed 2010-01-29

Associated revisions

Revision 16176
Added by Jean-Philippe Lang about 1 year ago

Adds settings to make the issue and/or comment fields mandatory for time logs (#24577).

Patch by Marius BALTEANU.

Revision 16177
Added by Jean-Philippe Lang about 1 year ago

Adds :setting_timelog_required_fields string to locales (#24577).

History

#1 Updated by Marius BALTEANU about 1 year ago

Attached the correct patch.

#2 Updated by Go MAEDA about 1 year ago

  • Duplicated by Feature #4885: Option to make time log comments field mandatory added

#3 Updated by Go MAEDA about 1 year ago

  • Duplicated by Feature #12236: Option to make Comment field required added

#4 Updated by Go MAEDA about 1 year ago

#5 Updated by Go MAEDA about 1 year ago

  • Duplicated by Defect #24049: Records in table time_entries with null value at field issue_id added

#6 Updated by Go MAEDA about 1 year ago

  • Target version set to Candidate for next major release

This is a long awaited feature. There are at least 4 duplicate issues.
The patch works fine for me.

#7 Updated by Go MAEDA about 1 year ago

  • Duplicated by Patch #2196: Do not save @time_entry if comment/hour is nil added

#8 Updated by Go MAEDA about 1 year ago

  • Duplicated by Feature #11039: Disable time tracking for projects added

#9 Updated by Go MAEDA about 1 year ago

  • Duplicated by Feature #4690: Make it configurable to make the issue number mandatory when booking hours added

#10 Updated by Go MAEDA about 1 year ago

  • Target version changed from Candidate for next major release to 3.4.0

There are many duplicate issues, many people longing for this feature.
Setting target version to 3.4.0.

#11 Updated by Jean-Philippe Lang about 1 year ago

  • Tracker changed from Patch to Feature
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch committed, thanks. It's a nice addition.

#12 Updated by ivan perez 10 months ago

Hello, this is a very good addition, i tried to apply the patch but my company is argentitnian so we have the spanish version, can anybody help me?, because this patch modify the en.yml file and in my case i have to modify the ES.yml file.

I can't wait until the 3.4 version comes...

i have redmine 3.2.2 so, i wait for your answer.

PD: it will be perfect if the patch allows to choose witch type of issue i want to make it mandatory..

If anybody can make the patch for redmine 3.2.2 spanish version and allows me to choose the type of issue i want to make it mandatory i will apreciate it so much.

Thanks a lot i wait for your answers

(Sorry for my english)

#13 Updated by Pierre de LESPINAY 4 months ago

I tried to apply the patch in a version 3.2.5-1 (Since I can't just upgrade to 3.4)

/home/redmine/redmine$ patch -p1 < settings_to_make_issue_id_comment_fields_mandatory_v2.patch

But I have 3 fails:

patching file app/helpers/settings_helper.rb
patching file app/models/time_entry.rb
patching file app/views/settings/_timelog.html.erb
patching file app/views/timelog/_form.html.erb
Hunk #1 FAILED at 12.
1 out of 1 hunk FAILED -- saving rejects to file app/views/timelog/_form.html.erb.rej
patching file config/locales/en.yml
Hunk #1 FAILED at 448.
1 out of 1 hunk FAILED -- saving rejects to file config/locales/en.yml.rej
patching file config/settings.yml
Hunk #1 FAILED at 279.
1 out of 1 hunk FAILED -- saving rejects to file config/settings.yml.rej
patching file test/unit/time_entry_test.rb

Is it supposed to be applyable on a 3.2.5-1 version ?

#14 Updated by Marius BALTEANU 3 months ago

Pierre de LESPINAY wrote:

Is it supposed to be applyable on a 3.2.5-1 version ?

No, it was never tested against 3.2.* or 3.3.* versions.

#15 Updated by Go MAEDA 19 days ago

  • Related to Defect #24722: Error when trying to reassign spent time when deleting issues from different projects added

#16 Updated by Go MAEDA 19 days ago

  • Related to deleted (Defect #24722: Error when trying to reassign spent time when deleting issues from different projects)

#17 Updated by Go MAEDA 19 days ago

  • Related to Defect #28110: Don't allow reassigning reported hours to the project if issue is a required field for time logs added

Also available in: Atom PDF