Project

General

Profile

Actions

Defect #26892

closed

Link to user in wiki syntax only works when login is written in lower case

Added by Anders Thomsen over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Related: #4179

The plugin "Redmine Mentions" gives a handy dropdown with users when hitting "@" on the keyboard. Selecting a user puts "@loginname" in the textbox. This works great with the feature implemented in #4179. However, if the user's login contains capital letters it is not recognized by the regex in application_helper.

"Redmine mentions" puts in the actual login-name with exact casing (what I believe is the correct behaivour).

The regex should be ajusted to a-zA-Z


Files


Related issues

Related to Redmine - Feature #4179: Link to user in wiki syntaxClosedJean-Philippe Lang2009-11-08

Actions
Has duplicate Redmine - Defect #32382: Unreliable User mention feature with PostgreSQLClosed

Actions
Blocked by Redmine - Defect #26443: User link syntax (user:login) doesn't work for logins consisting of an email adressClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Go MAEDA over 6 years ago

Actions #2

Updated by Toshi MARUYAMA over 6 years ago

  • Target version set to 4.1.0
Actions #3

Updated by Marius BĂLTEANU almost 6 years ago

  • Blocked by Defect #26443: User link syntax (user:login) doesn't work for logins consisting of an email adress added
Actions #5

Updated by Marius BĂLTEANU almost 6 years ago

  • Status changed from New to Confirmed
Actions #6

Updated by Jean-Philippe Lang almost 6 years ago

  • Assignee set to Marius BĂLTEANU

Marius, I have applied #26443 and I'm getting a failure for the test included in this patch:

Failure:
ApplicationHelperTest#test_redmine_links [test/helpers/application_helper_test.rb:406]:
user:JSMITH failed.
Expected: "<p><a class=\"user active\" href=\"/users/2\">John Smith</a></p>" 
  Actual: "<p>user:JSMITH</p>" 

Can you have a look please?

Actions #7

Updated by Go MAEDA almost 6 years ago

Jean-Philippe Lang wrote:

Marius, I have applied #26443 and I'm getting a failure for the test included in this patch:

This is a workaround for the error.

Index: app/helpers/application_helper.rb
===================================================================
--- app/helpers/application_helper.rb    (revision 17395)
+++ app/helpers/application_helper.rb    (working copy)
@@ -975,12 +975,12 @@
                 link = link_to_project(p, {:only_path => only_path}, :class => 'project')
               end
             when 'user'
-              u = User.visible.where(:login => name, :type => 'User').first
+              u = User.visible.where("LOWER(login) = :s AND type = 'User'", :s => name.downcase).first
               link = link_to_user(u, :only_path => only_path) if u
             end
           elsif sep == "@" 
             name = remove_double_quotes(identifier)
-            u = User.visible.where(:login => name, :type => 'User').first
+            u = User.visible.where("LOWER(login) = :s AND type = 'User'", :s => name.downcase).first
             link = link_to_user(u, :only_path => only_path) if u
           end
         end
Actions #8

Updated by Marius BĂLTEANU almost 6 years ago

  • Assignee deleted (Marius BĂLTEANU)
  • Target version changed from 4.1.0 to 4.0.0

I agree with the workaround posted above by Go Maeda, it is enough to fix the failing test. It seems that on my local environment, the search is case insensitive and the test doesn't fail.

Actions #9

Updated by Go MAEDA almost 6 years ago

  • Assignee set to Jean-Philippe Lang
Actions #10

Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from Confirmed to Closed
  • Resolution set to Fixed

Committed, thanks.

Actions #11

Updated by Mischa The Evil over 4 years ago

  • Related to Defect #32382: Unreliable User mention feature with PostgreSQL added
Actions #12

Updated by Marius BĂLTEANU almost 4 years ago

  • Related to deleted (Defect #32382: Unreliable User mention feature with PostgreSQL)
Actions #13

Updated by Marius BĂLTEANU almost 4 years ago

  • Has duplicate Defect #32382: Unreliable User mention feature with PostgreSQL added
Actions

Also available in: Atom PDF