Defect #28079

The green tick is positioned after the label in the new member modals

Added by Marius BALTEANU 5 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:3.4.5
Resolution:Fixed Affected version:

Description

This is a patch extracted from #27807 in order to fix it earlier (in a minor version)

The green tick is positioned after the label in the new member modals from:
- admin (Users -> Edit user -> Projects -> Add Project)
- project setting (Project setting -> Membership -> New members)

I've attached:
- two screenshots with the issue
- a patch that fixes these issues.

project_settings_membership.png (214 KB) Marius BALTEANU, 2018-01-26 00:46

admin_membership.png (127 KB) Marius BALTEANU, 2018-01-26 00:46

fix_tick_position_in_membership_modals.patch Magnifier (2.68 KB) Marius BALTEANU, 2018-01-26 00:49

remove_useless_empty_space.patch Magnifier (1.32 KB) Marius BALTEANU, 2018-02-22 21:23

screenshoot.png (99.2 KB) Marius BALTEANU, 2018-02-22 21:25


Related issues

Related to Redmine - Patch #27807: Use a unique way to check/uncheck a group/fieldset with c... Closed

Associated revisions

Revision 17207
Added by Go MAEDA 4 months ago

Fix: The green tick is positioned after the label in the new member modals (#28079).

Patch by Marius BALTEANU.

Revision 17208
Added by Go MAEDA 4 months ago

Merged r17207 from trunk to 3.4-stable (#28079).

Revision 17209
Added by Go MAEDA 4 months ago

Remove useless empty spaces (#28079).

Patch by Marius BALTEANU.

Revision 17210
Added by Go MAEDA 4 months ago

Merged r17209 from trunk to 3.4-stable (#28079).

History

#1 Updated by Marius BALTEANU 5 months ago

  • Related to Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes added

#2 Updated by Mischa The Evil 5 months ago

  • Description updated (diff)
  • Target version set to Unplanned

LGTM.

#3 Updated by Marius BALTEANU 4 months ago

Go Maeda, lets fix these UI issues in the next minor version.

#4 Updated by Go MAEDA 4 months ago

  • Target version changed from Unplanned to 3.4.5

This patch fixes UI inconsistency. In other pages, the green tick is placed before the label.

Setting target version to 3.4.5.

#5 Updated by Go MAEDA 4 months ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed. Thank you for improving Redmine.

#6 Updated by Marius BALTEANU 4 months ago

Thanks for fixing these issues.

I'm attaching a small fix for my previous patches in order to remove the useless empty space before the label.

It has no impact in the frontend, but it shouldn't be there.

#7 Updated by Go MAEDA 4 months ago

  • Status changed from Reopened to Closed

Committed the patch #28079#note-6. Thank you.

#8 Updated by Marius BALTEANU 4 months ago

Go MAEDA wrote:

Committed the patch #28079#note-6. Thank you.

Great, thanks!

#9 Updated by Go MAEDA 3 months ago

  • Assignee set to Go MAEDA

Also available in: Atom PDF