Patch #28602
closed
Move edit and delete buttons for queries to the buttons section
Added by Bernhard Rohloff about 6 years ago.
Updated almost 6 years ago.
Description
Except in the gantts view, in all query based views the edit and delete buttons are placed inside the buttons section (apply/clear/save) under the filters and options.
I think the gantts view should be aligned to the common UI pattern, as well.
In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.
Current view
Proposed view
Files
- Related to Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time views added
It'll be nice to deliver this change along with #26125.
- Target version set to Candidate for next major release
+1
The buttons on issues list page were moved in r15344. To make the UI consistent, I think also the buttons on gantt page should be moved to below the filters.
Bernhard Rohloff wrote:
In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.
I'm in favour of removing the empty contextual element and update the tests accordingly.
Marius BALTEANU wrote:
Bernhard Rohloff wrote:
In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.
I'm in favour of removing the empty contextual element and update the tests accordingly.
I am concerned that removing the div.contextual may affect some plugins which insert custom tags into the area.
- Target version changed from Candidate for next major release to 4.1.0
Setting target version to 4.1.0.
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from 4.1.0 to 4.0.0
Committed. Thank you for improving Redmine.
- Subject changed from [Gantt] Move edit and delete buttons for queries to the buttons section to Move edit and delete buttons for queries to the buttons section
Also available in: Atom
PDF
Updated by 
Updated by