Defect #30236

Accidentally clicking next to the checkbox breaks issue selection

Added by Aleksandar Pavic 8 months ago. Updated 6 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues list
Target version:4.0.2
Resolution:Fixed Affected version:3.4.6

Description

Expected behavior would be that issues don't get unchecked when clicking outside checkbox, and that clicked issue gets added to selection

selection.gif (152 KB) Aleksandar Pavic, 2018-12-17 14:50

vokoscreen-2019-01-03_09-16-00.gif (158 KB) Aleksandar Pavic, 2019-01-03 09:20

feature-30236.patch Magnifier (3.76 KB) Mizuki ISHIKAWA, 2019-01-08 07:18

label.png (76.5 KB) Mizuki ISHIKAWA, 2019-01-08 07:20

checkbox.gif (555 KB) Mizuki ISHIKAWA, 2019-01-08 07:21

Associated revisions

Revision 17830
Added by Jean-Philippe Lang 7 months ago

Accidentally clicking next to the checkbox breaks issue selection (#30236).

Revision 17892
Added by Jean-Philippe Lang 6 months ago

Merged r17830 to 4.0-stable (#30236).

History

#1 Updated by Aleksandar Pavic 8 months ago

Sorry its primary click. Some people swap buttons...

#2 Updated by Go MAEDA 8 months ago

I think the current behavior is natural. You can select multiple issues if you click issues while pressing Control/Command key.

#3 Updated by Aleksandar Pavic 8 months ago

Fore example, gmail is not behaving the way Redmine is. Gmail captures click anywhere on checkboxes parent TD element, here is screen capture...

Perhaps it should be left to per-theme setting...

#4 Updated by Mizuki ISHIKAWA 7 months ago

I wrote a patch to make the range up to the parent TD element of the checkbox a clickable range.

It is difficult to click without mistaking a small checkbox.
This small change should impxrove usability.

clikable range:

#5 Updated by Aleksandar Pavic 7 months ago

Thanks Mizuki, oh I love jQuery!!! target.closest smart solution, hopefully Redmine team will include your patch in some new release :)

#6 Updated by Go MAEDA 7 months ago

  • Target version set to Candidate for next minor release

#7 Updated by Go MAEDA 7 months ago

  • Target version changed from Candidate for next minor release to 4.1.0

LGTM. Setting the target version to 4.1.0.

#8 Updated by Jean-Philippe Lang 7 months ago

  • Subject changed from Right clicking on issue list breaks selection (unchecks all selected issues) to Accidentally clicking next to the checkbox breaks issue selection
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from 4.1.0 to 4.0.2
  • Resolution set to Fixed

I've committed a fix similar to the one proposed by Mizuki but that does not require to add labels on every checkboxes.

#9 Updated by Jean-Philippe Lang 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF