Patch #32014

Rounded corners on table.list elements

Added by Antonio McDeal 3 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.1.0

Description

Same motivation as in #32013
The patch doesn't make calendar and gantt tables rounded though, due to more complex structure that they have, hence requiring different approach.

rounded-tables(excl-calendar+gantt+mypage).patch Magnifier (846 Bytes) Antonio McDeal, 2019-09-04 18:55

roundedlisttables.png (40.5 KB) Antonio McDeal, 2019-09-04 19:31

roundedlisttables2.png (27.1 KB) Antonio McDeal, 2019-09-04 19:31

rounded-tables(excl-calendar+gantt+mypage)-v2.patch Magnifier (859 Bytes) Antonio McDeal, 2019-09-27 20:43


Related issues

Related to Redmine - Patch #32013: Rounded corners of the main menu Closed
Related to Redmine - Patch #32165: Rounded corners on table.cal Closed
Related to Redmine - Patch #32166: Rounded corners on table.gantt-table New

Associated revisions

Revision 18547
Added by Go MAEDA 3 months ago

Rounded corners on table.list elements (#32014).

Patch by Antonio McDeal.

History

#2 Updated by Bernhard Rohloff 3 months ago

  • Related to Patch #32013: Rounded corners of the main menu added

#3 Updated by Go MAEDA 3 months ago

The patch removes border-collapse property. Do you think it is OK? (sorry if this is a stupid question. I am not a CSS expert).

#4 Updated by Antonio McDeal 3 months ago

Go, roundness with border-radius on table elements can't seem to be achieved if border-collapse: collapse; is present, so I cleared it in a favor of border-spacing: 0; for this reason, which it did seem like does the same thing, only, unlike border-collapse, it doesn't block border-radius to be applied.

#5 Updated by Bernhard Rohloff 3 months ago

Yes, as Antonio wrote, it's necessary to get the border radius and border-spacing: 0; compensates it.
One notice of caution: I played with the border radius and found out that the cells don't get clipped to the round shape. Maybe an additional overflow: hidden; is missing here.

#6 Updated by Antonio McDeal 3 months ago

Bernhard Rohloff wrote:

Maybe an additional overflow: hidden; is missing here.

Not that it's a biggie, as our border radius doesn't seem to be that big anyway, for cells under to stick out, it's only 3px after all, but here is the patch with hidden overflow just in case ;-)

#7 Updated by Go MAEDA 3 months ago

  • Subject changed from Rounded corners on table/list elements to Rounded corners on table.list elements
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version set to 4.1.0

Committed the patch. Thank you for improving Redmine.

#8 Updated by Go MAEDA 3 months ago

  • Status changed from Closed to Reopened

I will revert this change because the change caused other changes such as #32165 and #32166 and I cannot predict how much the impact will spread further.

#9 Updated by Antonio McDeal 3 months ago

Go MAEDA wrote:

I will revert this change because the change caused other changes such as #32165 and #32166 and I cannot predict how much the impact will spread further.

#32165 and #32166 would be the last patches for the tables anyway, and it's really to be over with now after those two really small patches :D
Just calendar and gantt were styled and structured differently than list.tables and also each-other, hence why required separate patches.

Either way, I think it's better to keep it like that rather than reverting it, since gantt and calendar seem like the only exceptions anyway. Then deliver those two in later versions (if release will happen before they ready) if necessary.
We should probably add them as related too.

#10 Updated by Go MAEDA 2 months ago

  • Status changed from Reopened to Closed

#11 Updated by Go MAEDA 2 months ago

  • Related to Patch #32165: Rounded corners on table.cal added

#12 Updated by Go MAEDA 2 months ago

  • Related to Patch #32166: Rounded corners on table.gantt-table added

Also available in: Atom PDF