Rounded corners on table.list elements
|Assignee:||Go MAEDA||% Done:|
Same motivation as in #32013
The patch doesn't make calendar and gantt tables rounded though, due to more complex structure that they have, hence requiring different approach.
#4 Updated by Antonio McDeal 19 days ago
Go, roundness with border-radius on table elements can't seem to be achieved if border-collapse: collapse; is present, so I cleared it in a favor of border-spacing: 0; for this reason, which it did seem like does the same thing, only, unlike border-collapse, it doesn't block border-radius to be applied.
#5 Updated by Bernhard Rohloff 19 days ago
Yes, as Antonio wrote, it's necessary to get the border radius and
border-spacing: 0; compensates it.
One notice of caution: I played with the border radius and found out that the cells don't get clipped to the round shape. Maybe an additional
overflow: hidden; is missing here.
#6 Updated by Antonio McDeal 18 days ago
Bernhard Rohloff wrote:
Maybe an additional
overflow: hidden;is missing here.
Not that it's a biggie, as our border radius doesn't seem to be that big anyway, for cells under to stick out, it's only 3px after all, but here is the patch with hidden overflow just in case ;-)
#9 Updated by Antonio McDeal 18 days ago
Go MAEDA wrote:
#32165 and #32166 would be the last patches for the tables anyway, and it's really to be over with now after those two really small patches :D
Just calendar and gantt were styled and structured differently than list.tables and also each-other, hence why required separate patches.
Either way, I think it's better to keep it like that rather than reverting it, since gantt and calendar seem like the only exceptions anyway. Then deliver those two in later versions (if release will happen before they ready) if necessary.
We should probably add them as related too.