Issue page style. Reverse chronological order

Added by Konstantin Ashaev 7 months ago

Hi everybody,

I've got a question regarding the issue page style. After upgrade to Redmine 4, I noticed there is a white space between the issue's sections and history when I view comments in reverse chronological order. And this space increses as I add watchers. It is the same for both the default theme and third-party ones. Is that a new design or there is some issue in the page layout. Thanks.
PS Screenshot in the attachment.

Screenshot from 2019-06-13 09-15-32.jpg - white space (88.5 KB)

Replies (17)

RE: Issue page style. Reverse chronological order - Added by Seiei Miyagi 7 months ago

I think it was fixed recently

Defect \#31438: Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order \- Redmine

https://www.redmine.org/issues/31438

RE: Issue page style. Reverse chronological order - Added by Bernhard Rohloff 7 months ago

I've tried it in my dev environment right now and I can't reproduce these gap.
Changes affecting this area actually where (#31438) made in 4.0.4 but it definitely doesn't look as designed in your case. ;-)

Do you have a theme applied to your installation? Perhaps the changes could affect it and you need an updated one.
Another thing you can try is to refresh your sites cache by pressing CTRL + F5 to reload all static data.

Kind regards,

Bernhard

RE: Issue page style. Reverse chronological order - Added by Bernhard Rohloff 7 months ago

Seiei Miyagi wrote:

I think it was fixed recently

Defect \#31438: Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order \- Redmine

https://www.redmine.org/issues/31438

Regarding to the screenshot I think he has already updated to 4.0.4.

RE: Issue page style. Reverse chronological order - Added by Konstantin Ashaev 7 months ago

I did think it was fixed in 4.0.4. In my case there is just white space I don't have revisions.

RE: Issue page style. Reverse chronological order - Added by Konstantin Ashaev 7 months ago

Bernhard Rohloff wrote:

I've tried it in my dev environment right now and I can't reproduce these gap.
Changes affecting this area actually where (#31438) made in 4.0.4 but it definitely doesn't look as designed in your case. ;-)

Do you have a theme applied to your installation? Perhaps the changes could affect it and you need an updated one.
Another thing you can try is to refresh your sites cache by pressing CTRL + F5 to reload all static data.

Kind regards,

Bernhard

I use the latest version of Circle theme from RedmineUP (plus some of their plugins). My colleagues reported this issue, so this view is across all computers I watch for. In chronological order all seem fine.

RE: Issue page style. Reverse chronological order - Added by Bernhard Rohloff 7 months ago

Konstantin Ashaev wrote:

...
I use the latest version of Circle theme from RedmineUP (plus some of their plugins). My colleagues reported this issue, so this view is across all computers I watch for. In chronological order all seem fine.

I would suggest to temporarily switch back to Redmine's default theme to see if it's a theme problem. If the issue has disappeared in the default theme you know where you have to point at.

RE: Issue page style. Reverse chronological order - Added by Konstantin Ashaev 7 months ago

It's not gone if I switch to Redmine's default theme. See the attachment.

RE: Issue page style. Reverse chronological order - Added by Konstantin Ashaev 7 months ago

Other Screenshots of Default and Circle

RE: Issue page style. Reverse chronological order - Added by K G 3 months ago

Hello,

We are experiencing the same problem and have confirmed it's an issue with Reverse Chronological Order. From our tests, we believe this is a Redmine Core problem as there are two extraneous <div style="clear: both;"></div> that generate the gap. The Edit and Watch buttons appear to hang beneath the bottom most header of the right column.

RE: Issue page style. Reverse chronological order - Added by Dominik Ras 3 months ago

I'd try a different theme:
1. Redmine > Administration
2. Open Settings
3. From Display tab select a different theme and check the display
4. Scroll and click Save
5. Repeat steps 3 & 4 until things display the way you need them to.

I'm using Abacus office theme v1.3.4 ( https://www.abacusthemes.com/en/themes/redmine-theme ) by @RedmineUp
and things display just fine.

RE: Issue page style. Reverse chronological order - Added by Luis Blasco 3 months ago

I can confirm that in Zenmine and Boostmine themes (https://bestredminetheme.com) this gap is not shown.

RE: Issue page style. Reverse chronological order - Added by Bernhard Rohloff 3 months ago

K G wrote:

Hello,

We are experiencing the same problem and have confirmed it's an issue with Reverse Chronological Order. From our tests, we believe this is a Redmine Core problem as there are two extraneous <div style="clear: both;"></div> that generate the gap. The Edit and Watch buttons appear to hang beneath the bottom most header of the right column.

I think the problem comes from the action menu which flips to the top of the history when one selects reverse chronological order for the history tab. I don't face the issues you have, but I could imagine that for some esoteric browser defaults it could cause problems. IMHO, flipping the action menu with the order of the history is a bug, anyway.

RE: Issue page style. Reverse chronological order - Added by Bernhard Rohloff 3 months ago

I've submit a patch to fix it in #32370.
Testing and reporting the results is warmly welcomed. :-)

RE: Issue page style. Reverse chronological order - Added by Tam M 3 months ago

We seem to have a slightly different version of show.html.erb (? our code is from 4.0.5) but our patch based on your diff appears to solve the reverse chronological order gap problem. Thanks!

FILE_show.html.erb.patch Magnifier - our modified patch (661 Bytes)

RE: Issue page style. Reverse chronological order - Added by K G 3 months ago

Tam M wrote:

We seem to have a slightly different version of show.html.erb (? our code is from 4.0.5) but our patch based on your diff appears to solve the reverse chronological order gap problem. Thanks!

I can confirm that this is working in our environment, thanks for the patch Tam and Bernhard!

RE: Issue page style. Reverse chronological order - Added by Konstantin Ashaev 3 months ago

Tam M wrote:

We seem to have a slightly different version of show.html.erb (? our code is from 4.0.5) but our patch based on your diff appears to solve the reverse chronological order gap problem. Thanks!

Thank you very much! The gap has gone.
PS I tried the patch offered in #32370, but it couldn't be applied to show.html.erb used by our Redmine(4.0.4).

RE: Issue page style. Reverse chronological order - Added by Andrew Reshetov about 1 month ago

Try to apply this patch. It also solves problem but uses another method for this

(1-17/17)