Project

General

Profile

Actions

Defect #12981

closed

Wiki self-link with anchor looks strange in "preview" section.

Added by Vadim Pushtaev over 11 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Text formatting
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix
Affected version:

Description

My page named Wiki contains link [[Wiki#Section]]. It produces this HTML: <a href="#Section">Wiki</a> that looks great on the page, but look strange in preview section, while editing this page. In that case it directs me to /projects/project1/wiki/Wiki/edit#Section that is obviously wrong.

Self-link is considered like special case by this piece of code (app/helpers/application_helper.rb):

def parse_wiki_links
# ...
url = if anchor.present? && wiki_page.present? && (obj.is_a?(WikiContent) || obj.is_a?(WikiContent::Version)) && obj.page == wiki_page
  "##{anchor}" 
else

As you can see, obj.page == wiki_page is not enough to make link local.


Files

12981.diff (5.56 KB) 12981.diff Vadim Pushtaev, 2013-11-14 08:29

Related issues

Related to Redmine - Patch #16313: Allow to link to an anchor of the current wikipageClosedGo MAEDA

Actions
Actions

Also available in: Atom PDF