Project

General

Profile

Actions

Defect #12981

closed

Wiki self-link with anchor looks strange in "preview" section.

Added by Vadim Pushtaev over 11 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Text formatting
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix
Affected version:

Description

My page named Wiki contains link [[Wiki#Section]]. It produces this HTML: <a href="#Section">Wiki</a> that looks great on the page, but look strange in preview section, while editing this page. In that case it directs me to /projects/project1/wiki/Wiki/edit#Section that is obviously wrong.

Self-link is considered like special case by this piece of code (app/helpers/application_helper.rb):

def parse_wiki_links
# ...
url = if anchor.present? && wiki_page.present? && (obj.is_a?(WikiContent) || obj.is_a?(WikiContent::Version)) && obj.page == wiki_page
  "##{anchor}" 
else

As you can see, obj.page == wiki_page is not enough to make link local.


Files

12981.diff (5.56 KB) 12981.diff Vadim Pushtaev, 2013-11-14 08:29

Related issues

Related to Redmine - Patch #16313: Allow to link to an anchor of the current wikipageClosedGo MAEDA

Actions
Actions #1

Updated by Etienne Massip over 11 years ago

Yes and no, links generated in preview are not really supposed to be functional so the case is not taken into account.

Actions #2

Updated by wei hui over 11 years ago

  • File Screenshot_2013-01-21-09-14-40.png added
Actions #3

Updated by Jean-Philippe Lang over 11 years ago

  • File deleted (Screenshot_2013-01-21-09-14-40.png)
Actions #4

Updated by Vadim Pushtaev over 11 years ago

Is it really necessary to make link local? I mean, my browser doesn't refresh page anyway, even if full link to the same page is provided.

Actions #5

Updated by Etienne Massip over 11 years ago

ItLs useful for HTML export.

Actions #6

Updated by Vadim Pushtaev almost 11 years ago

I believe the appropriate strategy here is to never use local links in preview sections, it's pointless.

app/views/common/_preview.html.erb:

-<%= textilizable @text, :attachments => @attachments, :object => @previewed %>
+<%= textilizable @text, :attachments => @attachments, :object => @previewed, :wiki_links => :full %>

Patch with tests included.

Actions #7

Updated by Vadim Pushtaev almost 11 years ago

  • Status changed from New to Resolved
Actions #8

Updated by Go MAEDA over 3 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Wont fix

Please use [[#Section]] instead of [[Wiki#Section]] when you want to make a link to an anchor on the current page. The syntax is allowed since Redmine 4.0.0 (#16313). It should work as you expect.

Actions #9

Updated by Go MAEDA over 3 years ago

  • Related to Patch #16313: Allow to link to an anchor of the current wikipage added
Actions

Also available in: Atom PDF