Patch #12983

"Only for things I watch or I'm involved in" sends notifications only for issues

Added by Felix Schäfer about 6 years ago. Updated over 5 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Email notifications
Target version:-

Description

The e-mail notifications setting "Only for things I watch or I'm involved in" currently only sends notifications for issue updates. This has confused some of our (Plan.io) users because they didn't receive notifications for other things than issues they'd watch.

Patch is upcoming.

0001-Get-notified-about-other-watched-things-than-issues-.patch Magnifier (1.14 KB) Felix Schäfer, 2013-01-25 15:19


Related issues

Related to Redmine - Defect #8406: Missing notification "Only for things I watch or I'm assi... New 2011-05-19
Related to Redmine - Defect #13012: DE and FR: translation wrong for label_user_mail_option_o... New

History

#2 Updated by Jan Niggemann (redmine.org team member) about 6 years ago

Hi Felix,
just to make sure I understand the scenario correctly:
  1. User 1 sets watch=yes on something else than an issue, say, a wiki page
  2. User 2 changes that wiki page
  3. User 1 does not get a mail

I just tested this on 2.2.1 and I got a mail...
Edit: "Only for things I watch or I'm involved in" being my preference, of course.

#3 Updated by Felix Schäfer about 6 years ago

In your scenario, if user 1 has the email notification setting on "Only for things I watch or I'm involved in", he won't get an email. The german translation is a little misleading because it says "Only for issues I watch or I'm involved in", the french translation is also misleading because it says "Only for things I watch".

#4 Updated by Jan Niggemann (redmine.org team member) about 6 years ago

Felix Schäfer wrote:

The german translation is a little misleading because it says "Only for issues I watch or I'm involved in",

It reads 'Aufgaben'... I agree, that should be corrected...

the french translation is also misleading because it says "Only for things I watch".

Just like the french version, I'll include that.

In your scenario, if user 1 has the email notification setting on "Only for things I watch or I'm involved in", he won't get an email.

I checked that @work this afternoon and well, I got a mail...
I just tested at home and, alas, no mail.
The difference being that @work my user is an administrator...

I'll re-check tomorrow @work.

#5 Updated by Etienne Massip about 6 years ago

The current implementation states that it's only about Issues so changing it require an update of this statement, all the different case to be dealt with and some unit tests for "things" other than issues.

#6 Updated by Felix Schäfer about 6 years ago

Etienne Massip wrote:

The current implementation states that it's only about Issues so changing it require an update of this statement, all the different case to be dealt with and some unit tests for "things" other than issues.

The statement is in the code, yes, but the email notifications options don't reflect that (except in the german translation).

I first wanted to hear the consensus about this issue before fixing everything around it. If you say this is OK for core I'll happily update the patch to correct the comment, tests and german, french and english translations. If you think this shouldn't go into Redmine, I obviously don't need to do the work :-)

#7 Updated by Felix Schäfer over 5 years ago

Any news on this?

Also available in: Atom PDF