Defect #13723: Collapse doesn't work with section edit link - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Defect #13723

closed

Collapse doesn't work with section edit link

Added by Vadim Pushtaev over 13 years ago. Updated 14 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Text formatting

Target version:

6.0.11

Resolution:

Fixed

Affected version:

2.3.0

Description

Collapsed with collapse macro sections don't have an edit link. More than this, all following edit links don't work properly, because service-side numeration take into account all sections, even collapsed, but client-side doesn't.

Files

Download all files

expand-macros-before-parsing-sections.patch (747 Bytes) expand-macros-before-parsing-sections.patch		Marcin Szewczyk, 2023-06-13 14:39
clipboard-202306211125-xdbw9.png (47.2 KB) clipboard-202306211125-xdbw9.png		Go MAEDA, 2023-06-21 04:25
0001-Fix-section-edit-links-inside-and-after-the-collapse.patch (3.54 KB) 0001-Fix-section-edit-links-inside-and-after-the-collapse.patch		Marius BĂLTEANU, 2026-06-16 23:52

Related issues

	Related to Redmine - Defect #26974: Collapse macro conflicts with header section edit buttons	Closed					Actions
	Has duplicate Redmine - Defect #44164: Edit link is missing or incorrect in Wiki pages with the collapse macro	Closed					Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Vadim Pushtaev over 12 years ago

I can't reproduce the “more than this” part.

Considering the first part. Here is what we have in app/helpers/application_helper.rb (line 527):

macros = catch_macros(text)
#...
parse_sections(text, project, obj, attr, only_path, options)

catch_macros is a mutator, all instances of {{ macro ... }} in text are placed with {{macro(N)}}, so there is no chance parse_sections can see <h1>... inside. I don't know whether it was made on purpose or not, but I believe you can reject this issue.

Actions

Copy link

Updated by Asaf H over 12 years ago

It happens to me as well (the part before the "more than this").
Is there a reason you suggested rejecting this issue?

Actions

Copy link

Updated by Vadim Pushtaev over 12 years ago

It's not exactly a bug, it looks more like a feature.

Actions

Copy link

Updated by Asaf H over 12 years ago

Maybe an unavoidable behavior, but a feature?
If there are sections inside a collapser, why shouldn't the user be able to edit them?
I think it's best if the formatter treats the collapse as a section. That way you can edit the entire collapse, or any section within it, same as you would any section.

Actions

Copy link

Updated by Vadim Pushtaev over 12 years ago

Yeah, it would be perfect and natural, but unfortunately macros are just not made this way.

Actions

Copy link

Updated by Toshi MARUYAMA almost 9 years ago

Related to Defect #26974: Collapse macro conflicts with header section edit buttons added

Actions

Copy link

Updated by Marcin Szewczyk about 3 years ago

File expand-macros-before-parsing-sections.patch expand-macros-before-parsing-sections.patch added

Hi, in the 5.0.3 version the problem is still present. I attach a one-line patch that I intend to test on production (5.0.3) someday soon. For now I've tested it with version 4.2.3. app/helpers/application_helper.rb doesn't contain many changes between those versions so the patch should be still relevant. Testing via wiki edition (headings inside collapse, headings with inline code, TOC), running rake test and ruby test/helpers/application_helper_test.rb suggests it's OK. Although, I must admit that I may be missing something as I don't understand how the patch from r8841 fixed some of the problems. My ruby skills are almost nonexistent so I'm probably missing some scope nuances.

Actions

Copy link

Updated by Go MAEDA about 3 years ago

File clipboard-202306211125-xdbw9.png clipboard-202306211125-xdbw9.png added
Status changed from New to Confirmed

I have confirmed the issue and the patch posted in #note-7 fixes the issue.

Wiki page content:

h1. Test-13723

{{collapse
h2. foo

The quick brown fox jumps over the lazy dog.
}}

h2. bar

test test

With the patch applied:

Actions

Copy link

Updated by Marius BĂLTEANU 29 days ago

Has duplicate Defect #44164: Edit link is missing or incorrect in Wiki pages with the collapse macro added

Actions

Copy link

#10

Updated by Marius BĂLTEANU 29 days ago

File 0001-Fix-section-edit-links-inside-and-after-the-collapse.patch 0001-Fix-section-edit-links-inside-and-after-the-collapse.patch added
Target version set to Candidate for next minor release

I've added a test to the existing patch which still works.

Actions

Copy link

#11