Project

General

Profile

Actions

Patch #13774

closed

Show warning if CSV-Export exceeds limit

Patch #13774: Show warning if CSV-Export exceeds limit

Added by Daniel Felix over 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues
Target version:

Description

Hi there,

Filou Centrinov has reported a feature request in #13770. This patch aims to fix this.

Best regards,
Daniel


Files

patch_warning_on_csv_export.diff (3.12 KB) patch_warning_on_csv_export.diff Patch - Version 1 Daniel Felix, 2013-04-15 17:10
Screenshot.png (12.4 KB) Screenshot.png Screenshot after applying patch. Daniel Felix, 2013-04-15 17:10
patch_warning_on_csv_export_v2.diff (3.49 KB) patch_warning_on_csv_export_v2.diff Patch - Version 2 Daniel Felix, 2013-04-16 09:19

Related issues 1 (0 open — 1 closed)

Related to Redmine - Feature #13770: Show warning, when exported issues exceed the limitClosedJean-Philippe LangActions

Updated by Filou Centrinov over 13 years ago Actions #1

Three translation suggestions:
1st: EN: Export contains only %{export} of %{total} issues.
2nd: EN: Export contains only the first %{export} of %{total} issues.
3rd: EN: Export limit is {X}.

Also the pdf export needs a warning. I know, there is no dialog by default.

Updated by Filou Centrinov over 13 years ago Actions #2

I think like this it would be more simple and logical:

  <% if @issue_count > @csv_limit %>
  <div class="flash warning">
    <%= l(:warning_export_limit, :export => @csv_limit, :total => @issue_count) %>
  </div>
  <% end %>

Updated by Daniel Felix over 13 years ago Actions #3

Hi Filou,

your right the condition could be changed in this order. Well the result will be the same. :-)
I changed this in the patch.

In addition, I removed the .min. I added it in the first version (not uploaded here) to always display the count of the exported issues.

I changed the size of the modalbox and changed the translation to your suggestion nr. 1 in note 1.

If anyone has translations for this in his language, please provide them. I'll include them in the patch.

Best regards,
Daniel

Updated by Daniel Felix over 13 years ago Actions #4

Any news on this? Is this patch okay?

Updated by Jean-Baptiste Barth over 13 years ago Actions #5

  • Assignee set to Jean-Baptiste Barth

Seems ok at first sight, but needs a test or two so we won't break it inadvertently in a future release. I assign the issue to myself, I'll test it and write some tests tomorrow (except if you want to do so Daniel, would be great ;-))

Just one thing though, I'm always reluctant to add new locale keys (locale maintenance is a tiny nightmare). Isn't it possible to use the already existing setting_issues_export_limit ?

Updated by Jean-Philippe Lang almost 13 years ago Actions #6

  • Subject changed from Show warning if CSV-Export exceeds limits. to Show warning if CSV-Export exceeds limit
  • Status changed from New to Closed
  • Assignee changed from Jean-Baptiste Barth to Jean-Philippe Lang
  • Target version set to 2.5.0

Feature added in r12663. I used the existing i18n string and added some tests.

Actions

Also available in: PDF Atom