Project

General

Profile

Actions

Defect #14206

closed

Synchronize the lang attribute of the HTML with the display language

Defect #14206: Synchronize the lang attribute of the HTML with the display language

Added by Naoya Niwa over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
I18n
Target version:
Resolution:
Fixed
Affected version:

Description

Currently, lang attribute of HTML is specified "en" always regardless of the display language.


Files

patch-14206.diff (640 Bytes) patch-14206.diff Naoya Niwa, 2013-06-08 20:38
lang.diff (1.37 KB) lang.diff Toshi MARUYAMA, 2013-06-09 01:05
lang-V2.diff (1.37 KB) lang-V2.diff Toshi MARUYAMA, 2013-06-09 10:44

Related issues 1 (0 open — 1 closed)

Has duplicate Redmine - Defect #4009: "html" tag's xml:lang always "en" for all languagesClosedActions

Updated by Naoya Niwa over 13 years ago Actions #1

I made patch.
It gets the value of the lang attribute from I18n.locale.

Just in case, I made ​​sure the existing locales conform to BCP 47 by the following tool.

http://schneegans.de/lv/

Updated by Toshi MARUYAMA over 13 years ago Actions #2

  • Status changed from Resolved to New

Updated by Toshi MARUYAMA over 13 years ago Actions #3

Redmine defines wrapper "current_language".
source:tags/2.3.1/lib/redmine/i18n.rb#L111

Updated by Toshi MARUYAMA over 13 years ago Actions #4

This is a patch with tests.

Updated by Naoya Niwa over 13 years ago Actions #5

I appreciate all your help.
At the same time, please forgive my ignorance.

However, I think that should put double quotes around the value of the lang attribute.
I made ​​sure no problem otherwise.

Updated by Toshi MARUYAMA over 13 years ago Actions #6

Sorry, this is a patch with double quotes.

Updated by Naoya Niwa over 13 years ago Actions #7

  • Status changed from New to Resolved

Thank you very much indeed!

Updated by Toshi MARUYAMA over 13 years ago Actions #8

  • Status changed from Resolved to New

Updated by Toshi MARUYAMA over 13 years ago Actions #9

  • Target version set to 2.4.0

Updated by Filou Centrinov over 13 years ago Actions #10

  • Has duplicate Defect #4009: "html" tag's xml:lang always "en" for all languages added

Updated by Jean-Philippe Lang over 13 years ago Actions #11

  • Status changed from New to Closed
  • Resolution set to Fixed
Actions

Also available in: PDF Atom