Improve usage of label "button_update"
|Assignee:||Jean-Philippe Lang||% Done:|
Hi, today I discovered an improper german translation of
should better be
While the first has the meaning of "edit", the second corresponds to "update by applying my changes". Unfortunately,
button_update seems also to be used for editing issues:
$ grep -rn button_update app/ app/views/issues/_action_menu.html.erb:2:<%= link_to l(:button_update), edit_issue_path(@issue), :onclick => 'showAndScrollTo("update", "issue_notes"); return false;', :class => 'icon ico n-edit', :accesskey => accesskey(:edit) if @issue.editable? %> app/views/issues/show.html.erb:131: <h3><%= l(:button_update) %></h3> app/views/repositories/committers.html.erb:39:<p><%= submit_tag(l(:button_update)) %></p>
Therefore, I would suggest to change the translation and change
button_edit for the first two occurrences. It is fine for the third, I think.
What do you think? Comments welcome!