Patch #16190
Relax rejections based on Auto-Submitted header
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Email receiving | |||
| Target version: | 2.6.0 |
Description
One of our (Plan.io) uses an email server to forward messages to a Redmine instance which inserts Auto-Submitted: auto-forwarded headers to the forwarded emails. Those emails are then rejected because of source:/trunk/app/models/mail_handler.rb@12937#L69.
Putting the fact aside that this header is only part of an IETF draft and not of an RFC, and that even according to that draft it shouldn't be there, this header causes the forwarded emails to be reject. We propose changing the Regex to only match the undesirable values defined in RFC3834, i.e. /^auto-(replied|generated)/.
16190.patch 
(678 Bytes)
Related issues
Associated revisions
add "Auto-Submitted: auto-forwarded" to ignore mail test (#16190)
only ignore undesirable Auto-Submitted headers defined in RFC3834 (#16190)
Contributed by Felix Schäfer.
use \A instead of ^ for RegExp (#16190)
History
Updated by #2
Updated by Holger Just over 7 years ago
To cite from RFC 3834
Recipients of messages containing an Auto-Submitted field with any keyword other than "no" MAY assume that the message was not manually submitted by a human.
Thus, although it may be correct to swallow this email, it makes it much harder for people using kind-of-broken mail servers (like Lotus Domino) which forcefully include the Auto-Submitted: auto-forwarded header into all outgoing mails touched by their forwarding script.
In addition, given that forwarded mails generally are assumed to be valid, we could thus argue that the auto-forwarded mails are not to be dropped.
#3
Updated by Markus Plutka over 7 years ago
+1
#4
Updated by Jan Niggemann (redmine.org team member) over 7 years ago
Patch verified (and it's trivial anyway), can someone please merge this?
IMHO it's important that we merge such trivial patches right away and not let the contributor wait too long...
#5
Updated by Miquel Coll over 7 years ago
Jan Niggemann (redmine.org team member) wrote:
Patch verified (and it's trivial anyway), can someone please merge this?
IMHO it's important that we merge such trivial patches right away and not let the contributor wait too long...
I tried the patch in redmine-2.4.5 and worked fine. i'm using Lotus Domino and now the messages are not rejected.
#6
Updated by Toshi MARUYAMA over 7 years ago
- Target version set to 2.6.0
#7
Updated by Toshi MARUYAMA over 7 years ago
- Related to Feature #11338: Exclude emails with auto-submitted => auto-generated added
#8
Updated by Toshi MARUYAMA over 7 years ago
- Related to Defect #15999: Ignoring out of office emails added
#9
Updated by Toshi MARUYAMA over 7 years ago
- Status changed from New to Closed
#10
Updated by Toshi MARUYAMA almost 6 years ago
- Related to Defect #20465: MailHandler: ignoring email with Auto-Submitted:auto-generated header added