Patch #18290
closed
Added by Ondřej Ezr over 11 years ago.
Updated over 11 years ago.
Category:
Code cleanup/refactoring
Description
Issue safe_attribute 'is_private' cause a author loading if not necessary in some situations, and status_id_was is same as status_id, and it is not preventing loading if not changed.
Please accept, I hate patch all method, cuz one line change :(
Files
- Category set to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version set to 3.0.0
The author load fix is committed in r13576.
The second part is not OK and breaks a bunch of tests because #status_was would return nil if status was not changed, where it should return the current status. Fixed in r13577.
The last part is no longer in sync with trunk.
Thanks for your submission.
- Has duplicate Patch #17880: Performance issues on Issue model added
Also available in: Atom
PDF