Patch #20370

Lighter colors for journal details in issue history

Added by Go MAEDA almost 3 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.0

Description

This change makes easier to distinguish details (attachments, changes of statuses, assignees, ...) and notes in a issue history.

screenshot

journal-detail-background-color.diff Magnifier - patch (711 Bytes) Go MAEDA, 2015-07-19 08:44

sample-19097.png - screenshot (113 KB) Go MAEDA, 2015-07-19 08:49

FieldChanges.png (82.8 KB) budo kaiman, 2015-10-02 13:14

FilesAdded.png (115 KB) budo kaiman, 2015-10-02 13:14

patch-20151005.diff Magnifier (1.55 KB) Go MAEDA, 2015-10-04 18:03

Redmine_Pathch-20151005.png (97 KB) budo kaiman, 2015-10-05 13:53

patch-20151005_lighter.diff Magnifier (1.55 KB) budo kaiman, 2015-10-05 17:24

Redmine_patch-20151005_lighter.png (103 KB) budo kaiman, 2015-10-05 17:26

Associated revisions

Revision 14686
Added by Jean-Philippe Lang over 2 years ago

Lighter colors for journal details in issue history (#20370).

Patch by budo kaiman.

History

#1 Updated by Go MAEDA almost 3 years ago

  • Target version set to Candidate for next major release

#2 Updated by Michael Goegel almost 3 years ago

+1
Even with round corners to prevent injuries :o)

#3 Updated by Go MAEDA almost 3 years ago

  • Target version changed from Candidate for next major release to 3.2.0

#4 Updated by Jean-Philippe Lang over 2 years ago

Do we really want to highlight the journal details? Most of the time, people want them to be less visible. I would rather fade them out with something like color:#aaa.
I'd like to have more feedback on this before making any change.

#5 Updated by budo kaiman over 2 years ago

Jean-Philippe Lang wrote:

Do we really want to highlight the journal details? Most of the time, people want them to be less visible. I would rather fade them out with something like color:#aaa.
I'd like to have more feedback on this before making any change.

I agree that it should be less visible opposed to highlighting it, and your suggestion looks good when only fields have changed

But when files are attached, it doesn't seem to make much difference

#6 Updated by Jean-Philippe Lang over 2 years ago

budo kaiman wrote:

I agree that it should be less visible opposed to highlighting it, and your suggestion looks good when only fields have changed

But when files are attached, it doesn't seem to make much difference

We can choose a lighter blue for links. For example:

.journal ul.details {color:#aaa;}
.journal ul.details a {color:#8da3cc;}
.journal ul.details a:hover {color:#c61a1a;}

#7 Updated by Go MAEDA over 2 years ago

Thanks for feedback. I will make an updated patch.

#8 Updated by Go MAEDA over 2 years ago

Updated the patch.

  • From the viewpoint of readability, I think '#aaa' is too pale. Chose '#808080' (same color with activity description) for journal details and changed color of main text from '#484848' to '#333'.
  • Increased the separation between journal details and a note.

FYI: GitHub uses '#767676' and #333'. example: https://github.com/phusion/passenger/issues/1622

#9 Updated by budo kaiman over 2 years ago

I agree with the decision to use '#808080' and I think the patch looks much better.

Edit: On second thought, I think '#808080' might be a tad too dark. I tried a few values and found '#959595' to work well.

#10 Updated by budo kaiman over 2 years ago

Attaching a patch with some lighter values which I think work better and are still readable.

#11 Updated by Jean-Philippe Lang over 2 years ago

  • Subject changed from Set background color of journal details in a issue history to Lighter colors for journal details in issue history
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patch committed in r14686, thanks.

Also available in: Atom PDF