Patch #21258

Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive mode

Added by Daniel Ritz over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:3.2.0

Description

Patch 0003: use <ul> to do pagination for better styling capabilities
  • The outer p.pagination is changed to span.pagination. This is required since lists are not allowed within <p>
  • Change all items of the navigation to be <li>. This allows easy styling.

Patch 0004: change the pagination to a GitHub like style that is also easier to handle in responsive mode. Screenshot provided.

0004-Pagination-change-to-a-GitHub-like-style.patch Magnifier (1.73 KB) Daniel Ritz, 2015-11-17 15:35

0003-Pagination-use-ul-to-do-pagination-for-better-stylin.patch Magnifier (12.7 KB) Daniel Ritz, 2015-11-17 15:35

pagination-screenshot.png - Screenshot with patch 0004 applied (9.76 KB) Daniel Ritz, 2015-11-17 15:37

highlight-current-per-page-selection.diff Magnifier (932 Bytes) Go MAEDA, 2015-11-29 06:01

highlight-current-per-page-selection.png (14.1 KB) Go MAEDA, 2015-11-29 06:02


Related issues

Related to Redmine - Patch #23192: Add the new pagination style in the activity page Closed
Related to Redmine - Patch #26671: Use the new pagination style in gantt Closed
Related to Redmine - Patch #27346: Use the new pagination style for the calendars view New
Duplicated by Redmine - Patch #21245: UI/CSS refinements, part 1 Closed

Associated revisions

Revision 14897
Added by Jean-Philippe Lang over 2 years ago

Use ul tags to do pagination (#21258).

Patch by Daniel Ritz.

Revision 14898
Added by Jean-Philippe Lang over 2 years ago

Removed a space after spacer (#21258).

Revision 14899
Added by Jean-Philippe Lang over 2 years ago

Lighter colors (#21258).

Revision 14900
Added by Jean-Philippe Lang over 2 years ago

Adds a bottom margin for pagination (#21258).

Revision 14949
Added by Jean-Philippe Lang over 2 years ago

Highlight current per-page selection (#21258).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA over 2 years ago

  • Duplicated by Patch #21245: UI/CSS refinements, part 1 added

#2 Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next major release

+1
Wonderful inprovement.

Screenshot with patch 0004 applied

#3 Updated by Go MAEDA over 2 years ago

  • Target version changed from Candidate for next major release to 3.2.0

Thanks for working on this!
The work seems to be completed. Can target version be set to 3.2.0?

#4 Updated by Go MAEDA over 2 years ago

I think it would be better to make current per-page selection obvious.

#5 Updated by Jean-Philippe Lang over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

#6 Updated by Go MAEDA almost 2 years ago

  • Related to Patch #23192: Add the new pagination style in the activity page added

#7 Updated by Go MAEDA 10 months ago

  • Related to Patch #26671: Use the new pagination style in gantt added

#8 Updated by Marius BALTEANU 8 months ago

  • Related to Patch #27346: Use the new pagination style for the calendars view added

Also available in: Atom PDF