Patch #27346

Use the new pagination style for the calendars view

Added by Bernhard Rohloff about 1 year ago. Updated 3 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Calendar
Target version:4.1.0

Description

This patch converts the previous and next month links in the calendars view into buttons in the new pagination style. It also aligns the buttons vertically with the input fields on the left.

calendars_prev_and_next_month_pagination_style_r17016.diff Magnifier (1.58 KB) Bernhard Rohloff, 2017-11-01 07:34

screenshot_calendars_buttons.png (20 KB) Bernhard Rohloff, 2017-11-01 07:46


Related issues

Related to Redmine - Patch #21258: Use <ul> to do pagination, styling in a GitHub like manne... Closed

History

#1 Updated by Bernhard Rohloff about 1 year ago

This is the result of the patch...



#2 Updated by Go MAEDA about 1 year ago

  • Subject changed from Use the new pagination style for the calendars view. to Use the new pagination style for the calendars view
  • Category changed from UI to Calendar
  • Target version set to 4.1.0

It looks nice and improves the consistency of UI. I am setting target version to 4.1.0.
Thank you for posting the patch.

#3 Updated by Marius BALTEANU about 1 year ago

  • Related to Patch #21258: Use <ul> to do pagination, styling in a GitHub like manner with improved handling in responsive mode added

#4 Updated by Marius BALTEANU 3 months ago

This is another small change that can be included in 4.0.0.

#5 Updated by Go MAEDA 3 months ago

Marius BALTEANU wrote:

This is another small change that can be included in 4.0.0.

I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.

#6 Updated by Marius BALTEANU 3 months ago

Go MAEDA wrote:

Marius BALTEANU wrote:

This is another small change that can be included in 4.0.0.

I have not committed this patch because this patch changes a style ".buttons". The change influences all pages which use the class, not only the calendar page.

Oh, I need to admit that I didn't see that change.

#7 Updated by Bernhard Rohloff 3 months ago

I'm currently on the road but I can have a look at the patch on Sunday.
At a first glance I think the new styles came into the patch by accident.

#8 Updated by Bernhard Rohloff 3 months ago

Ok, I've looked at the patch and the style changes for the 'buttons' class are necessary to geht the new buttons for previous and next month in line with the form controls on the left.
After nearly a year passed by since I've submitted this patch I don't think it's the right solution anymore and I'll submit a better one for 4.1.0.

Also available in: Atom PDF