Feature #22147
closed
Change "Related issues" label for generic grouped query filters
Added by Sebastian Paluch almost 10 years ago.
Updated almost 10 years ago.
Description
The helper added to group filters of ":tree" and ":relation" type uses ":label_related_issues" as group label.
module QueriesHelper
include ApplicationHelper
def filters_options_for_select(query)
ungrouped = []
grouped = {}
query.available_filters.map do |field, field_options|
if [:tree, :relation].include?(field_options[:type])
group = :label_related_issues
elsif field =~ /^(.+)\./
# association filters
This is not OK as the helper is for all queries, not only for Issue queries. I my case I have a project query and group title "Related issues" does not match.
I would like to propose creating new, more generic label e.g. "label_related: Related".
- Description updated (diff)
- Category deleted (
Translations)
- Status changed from New to Needs feedback
- Related to Feature #13849: Grouped filters in the filter drop-down added
- Related to Feature #6118: Filter by parent task or subtasks added
Sebastian Paluch wrote:
This is not OK as the helper is for all queries, not only for Issue queries. I my case I have a project query and group title "Related issues" does not match.
Does it mean you use plugin which implement project query?
I have past in code that shows you where the :label_related_issues translation is used, I'm not talking about field_options[:type].
Yes, I have a plugin that implements project queries and in such case group called "Related Issues" is dummy. It should be more generic.
- Subject changed from Change translation for grouped query filters to Change "Related issues" for generic grouped query filters
- Status changed from Needs feedback to New
- Target version set to 3.3.0
- Subject changed from Change "Related issues" for generic grouped query filters to Change "Related issues" label for generic grouped query filters
- Category set to UI
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Replaced with :label_relations.
Also available in: Atom
PDF