Redmine

In the user/edit view, Firefox autofills the first password field. This is not useful behavior for a couple reasons:

• It fills in MY password, not the password of the user I'm editing
• The only use for those password fields is for changing passwords -- a user would never want that autofilled
• It fills in only the first password field, not the confirmation, so either I clear the field before I change any attributes
  on a user, or on validate it tells me the password fields don't match.

I think the best way to fix this is renaming the password form fields so they're not automatically filled in. You could
also clear the fields with javascript onload/dom:ready, and I actually did that at first, but it seemed less elegant.

Pasted the patches for 2 files below... hope this is the right way to do this, it's my first patch.

Index: app/views/users/_form.rhtml ===================================================================
--- app/views/users/_form.rhtml (revision 964)
+++ app/views/users/_form.rhtml (working copy)
@ -22,11 +22,11 @
<p><%= f.select :auth_source_id, ([[l(:label_internal), ""]] + @auth_sources.collect { |a| [a.name,
a.id] }), {}, :onchange => "if (this.value=='') {Element.show('password_fields');} else {Element.hide('password_fields');}" ></p>
< end >
<div id="password_fields" style="<= 'display:none;' if @user.auth_source >">
<p><label for="password"><=l(:field_password)%><span class="required">
</span></label>
<%= password_field_tag 'password', nil, :size => 25 ><br />
<p><label for="newpassword"><=l(:field_password)%><span class="required">
</span></label>
<%= password_field_tag 'newpassword', nil, :size => 25 ><br />
<em><= l(:text_caracters_minimum, 4) ></em></p>
<p><label for="password_confirmation"><=l(:field_password_confirmation)%><span
class="required"> *</span></label>
<%= password_field_tag 'password_confirmation', nil, :size => 25 ></p>
<p><label for="newpassword_confirmation"><=l(:field_password_confirmation)%><span
class="required"> *</span></label>
<%= password_field_tag 'newpassword_confirmation', nil, :size => 25 %></p>
</div>
</div>
<!--[eoform:user]-->

Index: app/controllers/users_controller.rb ===================================================================
--- app/controllers/users_controller.rb (revision 964)
++ app/controllers/users_controller.rb (working copy)
@ -57,11 +57,11 @
user user = User.new(params[:user])
@user.admin = params[:user][:admin] || false
@user.login = params[:user][:login]
- @user.password, @user.password_confirmation = params[:password], params[:password_confirmation] unless
@user.auth_source_id
@user.password, @user.password_confirmation = params[:newpassword], params[:newpassword_confirmation] unless
@user.auth_source_id
@custom_values = UserCustomField.find(:all, :order => "#{CustomField.table_name}.position").collect { |x| CustomValue.new(:custom_field => x, :customized => user, :value => (params[:custom_fields]
? params["custom_fields"][x.id.to_s] : nil)) }
@user.custom_values = @custom_values
if @user.save
- Mailer.deliver_account_information(@user, params[:password]) if params[:send_information]
+ Mailer.deliver_account_information(@user, params[:newpassword]) if params[:send_information]
flash[:notice] = l(:notice_successful_create)
redirect_to :action => 'list'
end
@ 76,7 76,7 @@
else
@user.admin = params[:user][:admin] if params[:user][:admin]
@user.login = params[:user][:login] if params[:user][:login]
@user.password, @user.password_confirmation = params[:password], params[:password_confirmation] unless
params[:password].nil? or params[:password].empty? or @user.auth_source_id
@user.password, @user.password_confirmation = params[:newpassword], params[:newpassword_confirmation] unless
params[:newpassword].nil? or params[:newpassword].empty? or @user.auth_source_id
if params[:custom_fields]
@custom_values = UserCustomField.find(:all, :order => "#{CustomField.table_name}.position").collect { |x| CustomValue.new(:custom_field => x, :customized => user user, :value =>
params["custom_fields"][x.id.to_s]) }
@user.custom_values = @custom_values