Project

General

Profile

Actions
Copy link

Patch #24382

closed

More readable regex for parse_redmine_links

Added by Dmitry Lisichkin over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Code cleanup/refactoring
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In method parse_redmine_links used very long regex that impossible to understand with first look.
Added names for capture groups.

Files

Download all files
parse_redmine_links_regexp_simplify.patch (2.74 KB) parse_redmine_links_regexp_simplify.patch Dmitry Lisichkin, 2016-11-16 12:32
parse_redmine_links_regexp_simplify1.patch (2.73 KB) parse_redmine_links_regexp_simplify1.patch Dmitry Lisichkin, 2016-12-23 08:22
Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 8 years ago

  • Target version set to 3.4.0
Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from New to Needs feedback

Breaks a test:

ruby test\unit\helpers\application_helper_test.rb
DL is deprecated, please use Fiddle
Run options: --seed 7252

# Running:

.............................................................E..................
....................

Finished in 2.519144s, 39.6960 runs/s, 154.0206 assertions/s.

  1) Error:
ApplicationHelperTest#test_parse_redmine_links_should_handle_a_tag_without_attri
butes:
NoMethodError: undefined method `+' for nil:NilClass
    app/helpers/application_helper.rb:943:in `block in parse_redmine_links'
    app/helpers/application_helper.rb:800:in `gsub!'
    app/helpers/application_helper.rb:800:in `parse_redmine_links'
    test/unit/helpers/application_helper_test.rb:1279:in `test_parse_redmine_lin
ks_should_handle_a_tag_without_attributes'

100 runs, 388 assertions, 0 failures, 1 errors, 0 skips
Actions
Copy link
 #3

Updated by Dmitry Lisichkin over 8 years ago

Sorry, wrong place for "tag_content" capture group.
Fixed.

Actions
Copy link
 #4

Updated by Go MAEDA over 8 years ago

  • Category changed from Text formatting to Code cleanup/refactoring
Actions
Copy link
 #5

Updated by Jean-Philippe Lang over 8 years ago

  • Subject changed from simplified regex for parse_redmine_links to More readable regex for parse_redmine_links
  • Status changed from Needs feedback to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks for fixing the patch.

Actions
Copy link
 #6

Updated by Mischa The Evil over 8 years ago

Dmitry, that's a nice refactoring making the method a lot more readable and thus easier to understand.

Actions
Copy link

Also available in: Atom PDF