Patch #24382
More readable regex for parse_redmine_links
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Code cleanup/refactoring | |||
| Target version: | 3.4.0 |
Description
In method parse_redmine_links used very long regex that impossible to understand with first look.
Added names for capture groups.
Associated revisions
More readable regexp for parse_redmine_links (#24382).
Patch by Dmitry Lisichkin.
History
#1
Updated by Toshi MARUYAMA over 2 years ago
- Target version set to 3.4.0
#2
Updated by Jean-Philippe Lang over 2 years ago
- Status changed from New to Needs feedback
Breaks a test:
ruby test\unit\helpers\application_helper_test.rb
DL is deprecated, please use Fiddle
Run options: --seed 7252
# Running:
.............................................................E..................
....................
Finished in 2.519144s, 39.6960 runs/s, 154.0206 assertions/s.
1) Error:
ApplicationHelperTest#test_parse_redmine_links_should_handle_a_tag_without_attri
butes:
NoMethodError: undefined method `+' for nil:NilClass
app/helpers/application_helper.rb:943:in `block in parse_redmine_links'
app/helpers/application_helper.rb:800:in `gsub!'
app/helpers/application_helper.rb:800:in `parse_redmine_links'
test/unit/helpers/application_helper_test.rb:1279:in `test_parse_redmine_lin
ks_should_handle_a_tag_without_attributes'
100 runs, 388 assertions, 0 failures, 1 errors, 0 skips
#3
Updated by Dmitry Lisichkin over 2 years ago
- File parse_redmine_links_regexp_simplify1.patch
added
Sorry, wrong place for "tag_content" capture group.
Fixed.
#4
Updated by Go MAEDA over 2 years ago
- Category changed from Text formatting to Code cleanup/refactoring
#5
Updated by Jean-Philippe Lang over 2 years ago
- Subject changed from simplified regex for parse_redmine_links to More readable regex for parse_redmine_links
- Status changed from Needs feedback to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks for fixing the patch.
#6
Updated by Mischa The Evil over 2 years ago
Dmitry, that's a nice refactoring making the method a lot more readable and thus easier to understand.