Patch #24800

Remove internal style sheet duplication and obsoleted meta tag from wiki_syntax_* documentation.

Added by Mischa The Evil almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Documentation
Target version:3.4.0

Description

In preparation of #24723, I would've started a second time of search-and-replacing, but I decided to fix the following duplication and obsoletion upfront:
  • extracted internal style sheets from wiki_syntax_detailed_[markdown|textile].html into an external one (wiki_syntax_detailed.css)
  • extracted internal style sheets from wiki_syntax_[markdown|textile].html into an external one (wiki_syntax.css)
  • removed old, obsoleted and unused 'Content-Style-Type' meta tag

I attach three patches implementing these changes. This patch serial, against current source:/trunk@16171, is produced using git format-patch which makes the individual patches apply-able using "patch -p1 < 0001-...".

0001-Extract-wiki_syntax_detailed-internal-style-sheets-i.patch Magnifier (156 KB) Mischa The Evil, 2017-01-10 15:19

0002-Extract-wiki_syntax-internal-style-sheets-into-an-ex.patch Magnifier (120 KB) Mischa The Evil, 2017-01-10 15:19

0003-Remove-old-and-obsolete-Content-Style-Type-meta-tag.patch Magnifier (55.3 KB) Mischa The Evil, 2017-01-10 15:19

Related issues

Related to Redmine - Defect #24723: [regression?] r10132's changes were reverted with r15569 Confirmed

Associated revisions

Revision 16206
Added by Jean-Philippe Lang almost 5 years ago

Extract wiki_syntax_detailed internal style sheets into an external one (#24800).

Patch by Mischa The Evil.

Revision 16207
Added by Jean-Philippe Lang almost 5 years ago

Extract wiki_syntax internal style sheets into an external one (#24800).

Patch by Mischa The Evil.

Revision 16208
Added by Jean-Philippe Lang almost 5 years ago

Remove old and obsolete 'Content-Style-Type' meta tag (#24800).

Patch by Mischa The Evil.

History

#1 Updated by Mischa The Evil almost 5 years ago

  • Related to Defect #24723: [regression?] r10132's changes were reverted with r15569 added

#2 Updated by Go MAEDA almost 5 years ago

  • Target version set to 3.4.0

I looked all updated public/help/*/wiki_syntax_*.html files and everything looks fine.
I should have done this work when I made the patch #14630. Thanks.

Setting target version to 3.4.0.

#3 Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Patches committed, thanks.

Also available in: Atom PDF