Project

General

Profile

Actions
Copy link

Patch #25014

closed

redmine/i18n.rb - languages_lookup class variable is rebuilt every time

Added by Jens Krämer almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
I18n
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

the @@languages_lookup variable in redmine/i18n.rb appears to be intended as a cache but is assigned to a new value everytime find_language is called.

Attached patch fixes this by using ||= instead of =.

Files

0001-turns-languages_lookup-into-a-cache-by-using.patch (758 Bytes) 0001-turns-languages_lookup-into-a-cache-by-using.patch Jens Krämer, 2017-02-06 11:56
Actions
Copy link
 #1

Updated by Go MAEDA almost 9 years ago

  • Target version set to 3.4.0

Since find_language method is called on every request, I think caching values is reasonable.
Setting target version to 3.4.0.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 8 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks for the fix.

Actions
Copy link

Also available in: Atom PDF