Patch #26149

Remove duplicate method shell_quote

Added by Jens Krämer about 1 year ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:3.4.0

Description

There are two identical methods shell_quote declared in Redmine::Utils::Shell and Redmine::Scm::Adapters::AbstractAdapter.

This patch removes the duplicate declaration from AbstractAdapter and also extracts a generic shell_quote_command method into Redmine::Utils::Shell.

0001-removes-duplicate-shell_quote-method.patch Magnifier (2.8 KB) Jens Krämer, 2017-06-13 08:36

Associated revisions

Revision 16667
Added by Jean-Philippe Lang about 1 year ago

Removes duplicate shell_quote method (#26149).

Patch by Jens Krämer.

History

#1 Updated by Go MAEDA about 1 year ago

  • Category changed from SCM to Code cleanup/refactoring
  • Target version set to 3.4.0

Jens Krämer wrote:

There are two identical methods shell_quote declared in Redmine::Utils::Shell and Redmine::Scm::Adapters::AbstractAdapter.

Indeed. Those two methods are completely identical. The patch looks good to me and passed all tests.
Setting target version to 3.4.0.

#2 Updated by Jean-Philippe Lang about 1 year ago

  • Subject changed from duplicate method shell_quote to Remove duplicate method shell_quote
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks!

Also available in: Atom PDF