Patch #26149
Remove duplicate method shell_quote
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Code cleanup/refactoring | |||
Target version: | 3.4.0 |
Description
There are two identical methods shell_quote
declared in Redmine::Utils::Shell
and Redmine::Scm::Adapters::AbstractAdapter
.
This patch removes the duplicate declaration from AbstractAdapter
and also extracts a generic shell_quote_command
method into Redmine::Utils::Shell
.
Associated revisions
Removes duplicate shell_quote method (#26149).
Patch by Jens Krämer.
History
#1
Updated by Go MAEDA almost 5 years ago
- Category changed from SCM to Code cleanup/refactoring
- Target version set to 3.4.0
Jens Krämer wrote:
There are two identical methods
shell_quote
declared inRedmine::Utils::Shell
andRedmine::Scm::Adapters::AbstractAdapter
.
Indeed. Those two methods are completely identical. The patch looks good to me and passed all tests.
Setting target version to 3.4.0.
#2
Updated by Jean-Philippe Lang almost 5 years ago
- Subject changed from duplicate method shell_quote to Remove duplicate method shell_quote
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Committed, thanks!