Patch #26149
closed
Remove duplicate method shell_quote
Added by Jens Krämer over 8 years ago.
Updated over 8 years ago.
Category:
Code cleanup/refactoring
Description
There are two identical methods shell_quote declared in Redmine::Utils::Shell and Redmine::Scm::Adapters::AbstractAdapter.
This patch removes the duplicate declaration from AbstractAdapter and also extracts a generic shell_quote_command method into Redmine::Utils::Shell.
Files
- Category changed from SCM to Code cleanup/refactoring
- Target version set to 3.4.0
Jens Krämer wrote:
There are two identical methods shell_quote declared in Redmine::Utils::Shell and Redmine::Scm::Adapters::AbstractAdapter.
Indeed. Those two methods are completely identical. The patch looks good to me and passed all tests.
Setting target version to 3.4.0.
- Subject changed from duplicate method shell_quote to Remove duplicate method shell_quote
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Also available in: Atom
PDF